public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "pexu@gcc-bugzilla.mail.kapsi.fi" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug driver/105568] New: Superfluous --jobserver-auth= check taints further diagnostics Date: Wed, 11 May 2022 13:56:08 +0000 [thread overview] Message-ID: <bug-105568-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105568 Bug ID: 105568 Summary: Superfluous --jobserver-auth= check taints further diagnostics Product: gcc Version: 13.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: driver Assignee: unassigned at gcc dot gnu.org Reporter: pexu@gcc-bugzilla.mail.kapsi.fi Target Milestone: --- Hi. When linking with -flto=jobserver both gcc/gcc.cc and gcc/lto-wrapper.cc check if MAKEFLAGS contains "--jobserver-auth=" and if so attempt to further scrutinize its contents. Unfortunately, detect_jobserver() (at gcc/gcc.cc), which is executed always when linking, silently removes the entire "--jobserver-auth=" (up until next space) shall this scrutinization attempt fail. This makes jobserver_active_p() (at gcc/lto-wrapper.cc) always complain about a missing "--jobserver-auth=". Indeed, this might be now technically true, but it is very confusing and misleading if this was done because detect_jobserver() was not satisfied with the given "--jobserver-auth=". There a many reasons why the given "--jobserver-auth=" might be treated as non-functioning. Either GNU make is using an another jobserver type (named semaphore), the given file descriptors are inaccessible because GNU make and GCC are using different emulation layers (e.g. Mingw and Cygwin) or those simply are indeed not inherited, i.e. user forgot to add `+' to invoking GNU rule. Therefore it might be still necessary to remove the "--jobserver-auth=" but I presume this should done after jobserver_active_p(). Actually, this is already being done, as the entire MAKEFLAGS is emptied unless jobserver logic is enabled.
next reply other threads:[~2022-05-11 13:56 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-11 13:56 pexu@gcc-bugzilla.mail.kapsi.fi [this message] 2022-10-27 4:52 ` [Bug driver/105568] [13 Regression] " pinskia at gcc dot gnu.org 2023-04-26 6:56 ` [Bug driver/105568] [13/14 " rguenth at gcc dot gnu.org 2023-07-27 9:23 ` rguenth at gcc dot gnu.org 2024-05-21 9:11 ` [Bug driver/105568] [13/14/15 " jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-105568-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).