public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/105618] [11/12/13 Regression] Missed loop body simplification by -O3 (trunk v.s. 10.3) Date: Tue, 17 May 2022 07:32:09 +0000 [thread overview] Message-ID: <bug-105618-4-kkFGHQcm1m@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-105618-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105618 --- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> --- There was quite some massaging in handling of PHI uses, notably we now have /* For PHI nodes the block we know sth about is the incoming block with the use. */ if (gimple_code (use_stmt) == GIMPLE_PHI) { /* In case the PHI node post-dominates the current insert location we can disregard it. But make sure it is not dominating it as well as can happen in a CFG cycle. */ if (commondom != bb && !dominated_by_p (CDI_DOMINATORS, commondom, bb) && dominated_by_p (CDI_POST_DOMINATORS, commondom, bb) /* If the blocks are possibly within the same irreducible cycle the above check breaks down. */ && !((bb->flags & commondom->flags & BB_IRREDUCIBLE_LOOP) && bb->loop_father == commondom->loop_father) && !((commondom->flags & BB_IRREDUCIBLE_LOOP) && flow_loop_nested_p (commondom->loop_father, bb->loop_father)) && !((bb->flags & BB_IRREDUCIBLE_LOOP) && flow_loop_nested_p (bb->loop_father, commondom->loop_father))) continue; and already the first !dominated_by_p (CDI_DOMINATORS, commondom, bb) check makes us not consider the sink opportunity. That was introduced as part of the fix for PR97330.
next prev parent reply other threads:[~2022-05-17 7:32 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-16 13:15 [Bug tree-optimization/105618] New: " shaohua.li at inf dot ethz.ch 2022-05-16 13:26 ` [Bug tree-optimization/105618] " pinskia at gcc dot gnu.org 2022-05-17 6:57 ` [Bug tree-optimization/105618] [11/12/13 Regression] " rguenth at gcc dot gnu.org 2022-05-17 7:32 ` rguenth at gcc dot gnu.org [this message] 2022-05-17 7:48 ` rguenth at gcc dot gnu.org 2022-05-17 8:46 ` cvs-commit at gcc dot gnu.org 2022-05-17 8:46 ` [Bug tree-optimization/105618] [11/12 " rguenth at gcc dot gnu.org 2022-05-19 12:47 ` cvs-commit at gcc dot gnu.org 2022-07-22 11:21 ` [Bug tree-optimization/105618] [11 " cvs-commit at gcc dot gnu.org 2022-07-22 11:22 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-105618-4-kkFGHQcm1m@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).