public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/105630] [10/11/12/13 Regression] '-fcompare-debug' failure w/ -O1 -ftree-parallelize-loops=2
Date: Wed, 18 May 2022 11:49:06 +0000	[thread overview]
Message-ID: <bug-105630-4-S64hfkyGoV@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105630-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105630

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Ah, the difference between this and PR105415 is that here the VAR_DECL n has
DECL_RTL set, so we don't go through
      /* This decl was probably optimized away.  */
      if (!op0
          /* At least label RTXen are sometimes replaced by
             NOTE_INSN_DELETED_LABEL.  Any notes here are not
             handled by copy_rtx.  */
          || NOTE_P (op0))
        {
          if (!VAR_P (exp)
              || DECL_EXTERNAL (exp)
              || !TREE_STATIC (exp)
              || !DECL_NAME (exp)
              || DECL_HARD_REGISTER (exp)
              || DECL_IN_CONSTANT_POOL (exp)
              || mode == VOIDmode
              || symtab_node::get (exp) == NULL)
            return NULL;

          op0 = make_decl_rtl_for_debug (exp);
          if (!MEM_P (op0)
              || GET_CODE (XEXP (op0, 0)) != SYMBOL_REF
              || SYMBOL_REF_DECL (XEXP (op0, 0)) != exp)
            return NULL;
        }
because op0 is non-NULL, so we go with
      else
        op0 = copy_rtx (op0);
instead.
So perhaps something like:
      else if (VAR_P (exp)
               && is_global_var (exp)
               && symtab_node::get (exp) == NULL)
        return NULL;
before the else or so?
But, we'll need to compare the effects on debug info with that change too.

  reply	other threads:[~2022-05-18 11:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 15:24 [Bug debug/105630] New: " asolokha at gmx dot com
2022-05-18 11:49 ` jakub at gcc dot gnu.org [this message]
2022-05-18 12:37 ` [Bug debug/105630] " rguenth at gcc dot gnu.org
2022-05-19  9:58 ` cvs-commit at gcc dot gnu.org
2022-05-19  9:59 ` [Bug debug/105630] [10/11/12 " jakub at gcc dot gnu.org
2022-06-28 10:49 ` jakub at gcc dot gnu.org
2023-07-07 10:43 ` [Bug middle-end/105630] [11/12 " rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105630-4-S64hfkyGoV@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).