public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/105643] [13 Regression] Code-Size regression for specrate 538.imagick_r
Date: Thu, 19 May 2022 10:31:15 +0000	[thread overview]
Message-ID: <bug-105643-4-uGvSWHYSTI@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105643-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105643

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
It seems there are a lot of loops like the following in FrameImage

            for (x=0; x < (ssize_t) width; x++)
            {
              SetPixelPacket(frame_image,&matte,q,frame_indexes);
              q++;
              frame_indexes++;
            }

and they are now vectorized with an alias runtime check and a vectorized
epilogue.  I'd say that's good.  The "bad" is that we are unswitching
all those loops twice:

magick/decorate.c:605:25: optimized: Unswitching loop on condition: _1874 <=
0.0
magick/decorate.c:605:25: optimized: Unswitching loop on condition: _1874 >=
6.5535e+4

which means we have three copies to vectorize at least.  Doesn't really
explain your opt-info reports reporting :605 16 times.

In fact, I don't see any vectorization with -march=skylake-avx512 here
(but I didn't use -funroll-loops which will only make a difference on RTL
so generally I'd avoid that).  Maybe I need to check with a compiler
that doesn't have some unswitching improvements queued (but the old should get
those opportunities as well I think).

  parent reply	other threads:[~2022-05-19 10:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18  9:06 [Bug tree-optimization/105643] New: " admin at levyhsu dot com
2022-05-18 10:03 ` [Bug tree-optimization/105643] " pinskia at gcc dot gnu.org
2022-05-18 12:47 ` rguenth at gcc dot gnu.org
2022-05-18 13:15 ` marxin at gcc dot gnu.org
2022-05-19  3:46 ` admin at levyhsu dot com
2022-05-19  8:51 ` admin at levyhsu dot com
2022-05-19  8:52 ` admin at levyhsu dot com
2022-05-19  9:11 ` admin at levyhsu dot com
2022-05-19 10:31 ` rguenth at gcc dot gnu.org [this message]
2022-05-31  3:56 ` crazylht at gmail dot com
2022-06-01  7:50 ` rguenther at suse dot de
2022-10-19 10:11 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105643-4-uGvSWHYSTI@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).