public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/105679] [12/13 Regression] extra -Warray-bounds warning added with -fsanitize=shift due to jump threading
Date: Fri, 29 Jul 2022 10:06:00 +0000	[thread overview]
Message-ID: <bug-105679-4-piO3WlJk9K@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105679-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105679

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:49ba4fdeb648c149fa7d964ba812084262c3d06f

commit r13-1891-g49ba4fdeb648c149fa7d964ba812084262c3d06f
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Jul 29 10:40:34 2022 +0200

    tree-optimization/105679 - disable backward threading of unlikely entry

    The following makes the backward threader reject threads whose entry
    edge is probably never executed according to the profile.  That in
    particular, for the testcase, avoids threading the irq == 1 check
    on the path where irq > 31, thereby avoiding spurious -Warray-bounds
    diagnostics

      if (irq_1(D) > 31)
        goto <bb 3>; [0.00%]
      else
        goto <bb 4>; [100.00%]

    ;;   basic block 3, loop depth 0, count 0 (precise), probably never
executed
      _2 = (unsigned long) irq_1(D);
      __builtin___ubsan_handle_shift_out_of_bounds (&*.Lubsan_data0, 1, _2);

      _3 = 1 << irq_1(D);
      mask_4 = (u32) _3;
      entry = instance_5(D)->array[irq_1(D)];
      capture (mask_4);
      if (level_6(D) != 0)
        goto <bb 7>; [34.00%]
      else
        goto <bb 5>; [66.00%]

    ;;   basic block 5, loop depth 0, count 708669600 (estimated locally),
maybe hot  if (irq_1(D) == 1)
        goto <bb 7>; [20.97%]
      else
        goto <bb 6>; [79.03%]

            PR tree-optimization/105679
            * tree-ssa-threadbackward.cc
            (back_threader_profitability::profitable_path_p): Avoid threading
            when the entry edge is probably never executed.

  parent reply	other threads:[~2022-07-29 10:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-21  0:32 [Bug c/105679] New: erroneous -Warray-bounds warning with sanitizer kees at outflux dot net
2022-05-21  0:33 ` [Bug c/105679] " kees at outflux dot net
2022-05-21  1:02 ` [Bug tree-optimization/105679] " pinskia at gcc dot gnu.org
2022-05-23  6:50 ` [Bug tree-optimization/105679] [12/13 Regression] extra -Warray-bounds warning added with -fsanitize=shift due to jump threading rguenth at gcc dot gnu.org
2022-07-29  8:19 ` rguenth at gcc dot gnu.org
2022-07-29 10:06 ` cvs-commit at gcc dot gnu.org [this message]
2022-07-29 10:06 ` [Bug tree-optimization/105679] [12 " rguenth at gcc dot gnu.org
2022-07-30 23:50 ` kees at outflux dot net
2022-08-01  8:01 ` rguenth at gcc dot gnu.org
2022-08-02  6:35 ` rguenth at gcc dot gnu.org
2022-10-06 17:27 ` kees at outflux dot net
2022-10-07  6:57 ` rguenth at gcc dot gnu.org
2022-10-08  2:31 ` kees at outflux dot net
2023-05-08 12:24 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105679-4-piO3WlJk9K@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).