From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 9F44D39502FB; Tue,  2 May 2023 20:16:20 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F44D39502FB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1683058580;
	bh=t2YkdNchPZhFpkydTXBBB/Gu7ey8h7oMKJFJ0qpnBOw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=dz5AQJVAfUtXVe8SlJz6HqsCGYS+t7DMds5JvsDkLfjXfx6UC27hrgUvaDWY8G/N2
	 neTQQrxjGDiqD/UIWO/iWeki5EG1f+frkzXvLixBWFZsPpNhibsupruS99mIEF3bWF
	 izMjC+Lh1C4jSmUcWcLeHPj2bFSb94JOLCoZjtc4=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/105685] [10/11 Regression] Bogus `-Wsuggest-attribute=cold`
 on function already marked as `__attribute__((cold))`
Date: Tue, 02 May 2023 20:16:19 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 12.1.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-105685-4-RcOm1UlRNv@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-105685-4@http.gcc.gnu.org/bugzilla/>
References: <bug-105685-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105685

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:c448f0d85c778eade1d8ae597744f6455285346f

commit r11-10730-gc448f0d85c778eade1d8ae597744f6455285346f
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sun Mar 26 20:15:05 2023 +0200

    predict: Don't emit -Wsuggest-attribute=3Dcold warning for functions wh=
ich
already have that attribute [PR105685]

    In the following testcase, we predict baz to have cold
    entry regardless of the user supplied attribute (as it call
    unconditionally a cold function), but still issue
    a -Wsuggest-attribute=3Dcold warning despite it having that attribute
    already.

    The following patch avoids that.

    2023-03-26  Jakub Jelinek  <jakub@redhat.com>

            PR ipa/105685
            * predict.c (compute_function_frequency): Don't call
            warn_function_cold if function already has cold attribute.

            * c-c++-common/cold-2.c: New test.

    (cherry picked from commit 7eca91d4781bb3df941f25c30b971dac66ba1b3d)=