public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/105686] [10/11/12/13 Regression] ICE: verify_flow_info failed: missing REG_EH_REGION note at the end of bb 8 with -fnon-call-exceptions
Date: Mon, 23 May 2022 09:41:15 +0000	[thread overview]
Message-ID: <bug-105686-4-AAaX6tE6Bp@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105686-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105686

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |ebotcazou at gcc dot gnu.org
   Last reconfirmed|                            |2022-05-23
           Priority|P3                          |P2

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
@@ -67,31 +63,11 @@
   179: NOTE_INSN_BASIC_BLOCK 3
     9: NOTE_INSN_DELETED
   183: x2:DI=[sp:DI+0x40]
-  184: x0:DI=[sp:DI+0x48]
-      REG_UNUSED x0:DI
-  185: x0:DI=[sp:DI+0x50]
-      REG_UNUSED x0:DI
-      REG_EH_REGION 0x2
   217: NOTE_INSN_BASIC_BLOCK 4
-  186: x0:DI=[sp:DI+0x58]
-      REG_UNUSED x0:DI
-      REG_EH_REGION 0x2
   218: NOTE_INSN_BASIC_BLOCK 5
-  187: x0:DI=[sp:DI+0x60]
-      REG_UNUSED x0:DI
-      REG_EH_REGION 0x2
   219: NOTE_INSN_BASIC_BLOCK 6
-  188: x0:DI=[sp:DI+0x68]
-      REG_UNUSED x0:DI
-      REG_EH_REGION 0x2
   220: NOTE_INSN_BASIC_BLOCK 7
-  189: x0:DI=[sp:DI+0x70]
-      REG_UNUSED x0:DI
-      REG_EH_REGION 0x2
   221: NOTE_INSN_BASIC_BLOCK 8
-  190: x0:DI=[sp:DI+0x78]
-      REG_UNUSED x0:DI
-      REG_EH_REGION 0x2
   226: NOTE_INSN_BASIC_BLOCK 9
   228: pc=L227
   229: barrier

while there's nothing wrong with the transform, cprop-hardreg likely lacks
cleanup of EH side-effects / edges.

      /* Detect obviously dead sets (via REG_UNUSED notes) and remove them.  */
      if (set
          && !RTX_FRAME_RELATED_P (insn)
          && NONJUMP_INSN_P (insn)
          && !may_trap_p (set)
          && find_reg_note (insn, REG_UNUSED, SET_DEST (set))
          && !side_effects_p (SET_SRC (set))
          && !side_effects_p (SET_DEST (set)))
        {
          bool last = insn == BB_END (bb);
          delete_insn (insn);
          if (last)
            break;
          continue;

using delete_insn_and_edges here fixes it but reg_cprop doesn't schedule
a CFG cleanup so that isn't enough.

leaving to RTL maintainers.

  parent reply	other threads:[~2022-05-23  9:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-21 12:21 [Bug rtl-optimization/105686] New: " zsojka at seznam dot cz
2022-05-23  7:04 ` [Bug rtl-optimization/105686] " rguenth at gcc dot gnu.org
2022-05-23  9:41 ` rguenth at gcc dot gnu.org [this message]
2022-05-23 12:08 ` marxin at gcc dot gnu.org
2022-06-28 10:49 ` jakub at gcc dot gnu.org
2022-10-26 23:25 ` pinskia at gcc dot gnu.org
2023-05-14 22:40 ` [Bug rtl-optimization/105686] [10/11/12/13/14 " pinskia at gcc dot gnu.org
2023-05-14 22:44 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105686-4-AAaX6tE6Bp@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).