public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/105705] [12/13 Regression] std::equal triggers incorrect -Wnonnull warning
Date: Tue, 24 May 2022 09:37:43 +0000	[thread overview]
Message-ID: <bug-105705-4-1WXs2WoO8l@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105705-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105705

--- Comment #7 from rguenther at suse dot de <rguenther at suse dot de> ---
On Tue, 24 May 2022, redi at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105705
> 
> --- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
> The warning started to be given without -Wsystem-headers with r12-1992
> 
> It was already present with -Wsystem-headers, but suppressed by default.

Skimming that it looks for whether the inline stack contains _only_
system headers now which means that any system header content inlined
into user code will now be warned on without -Wsystem-header.  That
might be OK if the system header code is just abstraction but for
more complicated code it's going to expose details not helpful
to the user.

We might want to change this to set m_allsyslocs to true if
the "tail" of the inline stack is in system header which boils down
to asking it for the original location - the intent wasn't to
do extra suppression (like for user code inlined into system header
context) but to expose more code to diagnostics which we are not
ready to do [in late diagnostics at least].

  parent reply	other threads:[~2022-05-24  9:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-23 19:04 [Bug libstdc++/105705] New: " derek.mauro at gmail dot com
2022-05-23 19:11 ` [Bug tree-optimization/105705] [12/13 Regression] " pinskia at gcc dot gnu.org
2022-05-24  7:23 ` rguenth at gcc dot gnu.org
2022-05-24  7:30 ` jakub at gcc dot gnu.org
2022-05-24  7:40 ` jakub at gcc dot gnu.org
2022-05-24  8:53 ` redi at gcc dot gnu.org
2022-05-24  8:58 ` redi at gcc dot gnu.org
2022-05-24  9:37 ` rguenther at suse dot de [this message]
2023-05-08 12:24 ` [Bug tree-optimization/105705] [12/13/14 " rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105705-4-1WXs2WoO8l@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).