From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 00493385741A; Tue, 21 Jun 2022 09:02:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 00493385741A From: "rguenth at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/105740] missed optimization switch transformation for conditions with duplicate conditions Date: Tue, 21 Jun 2022 09:02:24 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 12.1.0 X-Bugzilla-Keywords: missed-optimization X-Bugzilla-Severity: normal X-Bugzilla-Who: rguenth at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2022 09:02:25 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105740 --- Comment #4 from Richard Biener --- IIRC switch conversion was run early originally because it was supposed to improve inlining heuristics. One might view if-to-switch + switch-conversi= on as canonicalization which would mean running it before things like jump threading or loop opts (most don't like switches at least). Then one might view if-to-switch + switch-conversion as (target specific) code generation optimization (for that we also have pass_lower_switch, so one thing would be re-running if-to-switch before that again, supposed pass_lower_switch also performs the transforms switch-conversion does). I usually don't like running things again and again.=