[Bug c/105763] New: ice in outgoing_edge_range_p, at gimple-ra nge-gori.cc:1253

[Bug c/105763] New: ice in outgoing_edge_range_p, at gimple-ra nge-gori.cc:1253

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105763

            Bug ID: 105763
           Summary: ice in outgoing_edge_range_p, at gimple-ra
                    nge-gori.cc:1253
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

Created attachment 53048
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53048&action=edit
C source code

For the attached code, with compiler flag -O3, does this:

during GIMPLE pass: unswitch
rl2png.c: In function ‘rl2_decode_png’:
rl2png.c:1292:1: internal compiler error: in outgoing_edge_range_p, at
gimple-ra
nge-gori.cc:1253
0xa17888 gori_compute::outgoing_edge_range_p(irange&, edge_def*, tree_node*,
ran
ge_query&)
        ../../trunk.git/gcc/gimple-range-gori.cc:1253
0x2da292b evaluate_control_stmt_using_entry_checks
        ../../trunk.git/gcc/tree-ssa-loop-unswitch.cc:686
0x2da4e43 evaluate_bbs<evaluate_loop_insns_for_predicate(loop*,
predicate_vector
&, unswitch_predicate*, int, unsigned int*, unsigned
int*)::<lambda(basic_block)
> >
        ../../trunk.git/gcc/tree-ssa-loop-unswitch.cc:830
0x2da97b6 evaluate_loop_insns_for_predicate
        ../../trunk.git/gcc/tree-ssa-loop-unswitch.cc:876

The problem first seems to occur sometime between git hash 442cf0977a299394
and 850a9ce8bcca59c7, a distance of some 32 commits.

A reduction is running now and will be finishing in the next ten minutes.

[Bug c/105763] ice in outgoing_edge_range_p, at gimple-ra nge-gori.cc:1253

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105763

--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
Reduced C code is

int rl2_decode_png_bit_depth;
int *rl2_decode_png_p_data;
void rl2_decode_png_row_pointers() {
  unsigned sample_type = 0;
  _setjmp();
  switch (rl2_decode_png_bit_depth)
  case 6:
    sample_type = 7;
  png_destroy_read_struct();
  for (;;)
    switch (sample_type)
    case 3:
    case 5:
      *rl2_decode_png_p_data;
}

[Bug tree-optimization/105763] [13 Regression] ice in outgoing_edge_range_p, at gimple-ra nge-gori.cc:1253

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105763

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|12.0                        |13.0
   Target Milestone|---                         |13.0
            Summary|ice in                      |[13 Regression] ice in
                   |outgoing_edge_range_p, at   |outgoing_edge_range_p, at
                   |gimple-ra nge-gori.cc:1253  |gimple-ra nge-gori.cc:1253

[Bug tree-optimization/105763] [13 Regression] ice in outgoing_edge_range_p, at gimple-range-gori.cc:1253

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105763

David Binderman <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[13 Regression] ice in      |[13 Regression] ice in
                   |outgoing_edge_range_p, at   |outgoing_edge_range_p, at
                   |gimple-ra nge-gori.cc:1253  |gimple-range-gori.cc:1253
                 CC|                            |amacleod at redhat dot com

--- Comment #2 from David Binderman <dcb314 at hotmail dot com> ---
Git blame says:

90e88fd376bb (Andrew MacLeod    2020-10-06 12:12:53 -0400 1253)  
gcc_checking_assert (gimple_range_ssa_p (name));

Adding author. Git commit 156d7d8dbc8d65d3958486bc4112a7279935e47d might be a
likely
candidate.

[Bug tree-optimization/105763] [13 Regression] ice in outgoing_edge_range_p, at gimple-range-gori.cc:1253 since r13-754-ga1c9f779f7528342

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105763

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-05-30
            Summary|[13 Regression] ice in      |[13 Regression] ice in
                   |outgoing_edge_range_p, at   |outgoing_edge_range_p, at
                   |gimple-range-gori.cc:1253   |gimple-range-gori.cc:1253
                   |                            |since
                   |                            |r13-754-ga1c9f779f7528342
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-754-ga1c9f779f7528342, let me take a look.

[Bug tree-optimization/105763] [13 Regression] ICE in outgoing_edge_range_p, at gimple-range-gori.cc:1253 since r13-754-ga1c9f779f7528342

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105763

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.

[Bug tree-optimization/105763] [13 Regression] ICE in outgoing_edge_range_p, at gimple-range-gori.cc:1253 since r13-754-ga1c9f779f7528342

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105763

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
It ICEs because ranger asserts on SSA_NAME_OCCURS_IN_ABNORMAL_PHI (for whatever
reason...).  I have a fix.

[Bug tree-optimization/105763] [13 Regression] ICE in outgoing_edge_range_p, at gimple-range-gori.cc:1253 since r13-754-ga1c9f779f7528342

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105763

--- Comment #6 from Andrew Macleod <amacleod at redhat dot com> ---
yeah, from times of yore when the small set of callers made sure it was only
invoked on useful cases.  There were a lot of development asserts from initial
development.

There is no reason to trap, it can simply return false. ie


-  gcc_checking_assert (gimple_range_ssa_p (name));
+  if (!gimple_range_ssa_p (name))
+    return false;

[Bug tree-optimization/105763] [13 Regression] ICE in outgoing_edge_range_p, at gimple-range-gori.cc:1253 since r13-754-ga1c9f779f7528342

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105763

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:ae575e93b6f7fb7077940cb7410f899da184ec2d

commit r13-873-gae575e93b6f7fb7077940cb7410f899da184ec2d
Author: Richard Biener <rguenther@suse.de>
Date:   Mon May 30 13:19:38 2022 +0200

    tree-optimization/105763 - avoid abnormals with ranger queries

    In unswitching we use ranger to simplify switch statements so we
    have to avoid doing anything for abnormals.

    2022-05-30  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/105763
            * tree-ssa-loop-unswitch.cc (find_unswitching_predicates_for_bb):
            Check gimple_range_ssa_p.

            * gcc.dg/pr105763.c: New testcase.

[Bug tree-optimization/105763] [13 Regression] ICE in outgoing_edge_range_p, at gimple-range-gori.cc:1253 since r13-754-ga1c9f779f7528342

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105763

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.