From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id E4B803852761; Wed,  3 May 2023 15:19:19 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4B803852761
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1683127159;
	bh=et/nOa5CudYacblFvu1YAaUA0gmKonikaf5/MxmC6EQ=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=WKMBtQohk2RKkaL8t/HpdLKLdYRZVdBKmVvjxybCqD9FyT6Oth4WQ/ZsBKSDwi6G3
	 8Woat1fdLkdhM6Ze+dvYnd1tcgge3SdxCuF6H7R/ajxFuajmRzjKiXgqsllGVY8kGL
	 gIxpzkaI5bMbmmpJ50sKCrty0kFRoh7gsSId7tZ4=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/105774] Bogus overflow in constant expression with signed
 char++
Date: Wed, 03 May 2023 15:19:19 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 12.1.1
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-105774-4-CifbA2Ngk0@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-105774-4@http.gcc.gnu.org/bugzilla/>
References: <bug-105774-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105774

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:11bf3345c74139c05c405d3e5bc73ee8d9e7d6a6

commit r10-11340-g11bf3345c74139c05c405d3e5bc73ee8d9e7d6a6
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Oct 24 16:25:29 2022 +0200

    c++: Fix up constexpr handling of char/signed char/short pre/post
inc/decrement [PR105774]

    signed char, char or short int pre/post inc/decrement are represented by
    normal {PRE,POST}_{INC,DEC}REMENT_EXPRs in the FE and only gimplificati=
on
    ensures that the {PLUS,MINUS}_EXPR is done in unsigned version of those
    types:
        case PREINCREMENT_EXPR:
        case PREDECREMENT_EXPR:
        case POSTINCREMENT_EXPR:
        case POSTDECREMENT_EXPR:
          {
            tree type =3D TREE_TYPE (TREE_OPERAND (*expr_p, 0));
            if (INTEGRAL_TYPE_P (type) && c_promoting_integer_type_p (type))
              {
                if (!TYPE_OVERFLOW_WRAPS (type))
                  type =3D unsigned_type_for (type);
                return gimplify_self_mod_expr (expr_p, pre_p, post_p, 1, ty=
pe);
              }
            break;
          }
    This means during constant evaluation we need to do it similarly (either
    using unsigned_type_for or using widening to integer_type_node).
    The following patch does the latter.

    2022-10-24  Jakub Jelinek  <jakub@redhat.com>

            PR c++/105774
            * constexpr.c (cxx_eval_increment_expression): For signed types
            that promote to int, evaluate PLUS_EXPR or MINUS_EXPR in int ty=
pe.

            * g++.dg/cpp1y/constexpr-105774.C: New test.

    (cherry picked from commit da8c362c4c18cff2f2dfd5c4706bdda7576899a4)=