[Bug c++/105803] New: [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[Bug c++/105803] New: [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

            Bug ID: 105803
           Summary: [13 regression] ICE at gcc/cp/pt.cc:27737 after
                    r13-860-gff91735a5b861d
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:ff91735a5b861dd6eaf2c1e511f26a9255898e7d, r13-860-gff91735a5b861d

This is occurring in one of the spec2017 test cases, 510.parest_r.


/home/seurer/gcc/git/install/gcc-test/bin/g++ -c -o
source/multigrid/mg_transfer_block.o -DSPEC -DNDEBUG -Iinclude -I.
-DSPEC_AUTO_SUPPRESS_OPENMP  -m64 -O3 -mcpu=power9 -ffast-math -funroll-loops
-fpeel-loops -fvect-cost-model -mpopcntd -mrecip=rsqrt    -DSPEC_LP64
-Wno-deprecated-declarations -std=c++14    -fpermissive 
source/multigrid/mg_transfer_block.cc
source/multigrid/mg_transfer_block.cc: In member function 'void
dealii::MGTransferBlockBase::build_matrices(const dealii::DoFHandler<dim,
spacedim>&, const dealii::MGDoFHandler<dim, spacedim>&)':
source/multigrid/mg_transfer_block.cc:119:20: internal compiler error: in
type_dependent_expression_p, at cp/pt.cc:27737
  118 |       prolongation_sparsities
      |       ~~~~~~~~~~~~~~~~~~~~~~~
  119 |         .push_back (std_cxx1x::shared_ptr<BlockSparsityPattern> (new
BlockSparsityPattern));
      |        
~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
0x1063cb33 type_dependent_expression_p(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:27737
0x1063d6f3 value_dependent_expression_p(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:27465
0x1063df77 value_dependent_expression_p(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:27707
0x106447cf any_value_dependent_elements_p(tree_node const*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:28184
0x103a7257 is_nondependent_constant_expression(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/constexpr.cc:9673
0x103a7913 fold_non_dependent_expr_template
        /home/seurer/gcc/git/gcc-test/gcc/cp/constexpr.cc:8172
0x10636ea3 build_non_dependent_expr(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:28647
0x106379a3 make_args_non_dependent(vec<tree_node*, va_gc, vl_embed>*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:28729
0x1033ea53 build_new_method_call(tree_node*, tree_node*, vec<tree_node*, va_gc,
vl_embed>**, tree_node*, int, tree_node**, int)
        /home/seurer/gcc/git/gcc-test/gcc/cp/call.cc:10939
0x105d91e7 cp_parser_postfix_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:7856
0x105fddd3 cp_parser_unary_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:9037
0x105b0307 cp_parser_cast_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:9941
0x105b0e83 cp_parser_binary_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:10043
0x105b1aff cp_parser_assignment_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:10347
0x105b5d33 cp_parser_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:10517
0x105ba46b cp_parser_expression_statement
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:12734
0x105d22ff cp_parser_statement
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:12526
0x105d3803 cp_parser_statement_seq_opt
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:12883
0x10613277 cp_parser_already_scoped_statement
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:14513
0x1061378b cp_parser_iteration_statement
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:14147


commit ff91735a5b861dd6eaf2c1e511f26a9255898e7d (HEAD)
Author: Marek Polacek <polacek@redhat.com>
Date:   Fri May 13 20:09:53 2022 -0400

    c++: Add !TYPE_P assert to type_dependent_expression_p [PR99080]

[Bug c++/105803] [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Would there be a chance to get a reduced testcase?

[Bug c++/105803] [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

--- Comment #2 from seurer at gcc dot gnu.org ---
With a bit of hacking with a chainsaw I got it to this:


#include <vector>
#include <memory>

class SparsityPattern
{
  public:
};

template <class SparsityPatternBase>
class BlockSparsityPatternBase// : public Subscriptor
{
};

class BlockSparsityPattern :  public BlockSparsityPatternBase<SparsityPattern>
{
};


class MGTransferBlockBase
{
  public:
    std::vector<std::shared_ptr<BlockSparsityPattern> >
prolongation_sparsities;
    template <int dim, int spacedim>
    void build_matrices ();
};

template <int dim, int spacedim>
void MGTransferBlockBase::build_matrices ()
{
  prolongation_sparsities.push_back (std::shared_ptr<BlockSparsityPattern> (new
BlockSparsityPattern));
}



/home/seurer/gcc/git/install/gcc-test/bin/g++ -c test.cc



test.cc: In member function 'void MGTransferBlockBase::build_matrices()':
test.cc:31:37: internal compiler error: in type_dependent_expression_p, at
cp/pt.cc:27737
   31 |   prolongation_sparsities.push_back
(std::shared_ptr<BlockSparsityPattern> (new BlockSparsityPattern));
      |  
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
0x1063cb33 type_dependent_expression_p(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:27737
0x1063d6f3 value_dependent_expression_p(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:27465
0x1063df77 value_dependent_expression_p(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:27707
0x106447cf any_value_dependent_elements_p(tree_node const*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:28184
0x103a7257 is_nondependent_constant_expression(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/constexpr.cc:9673
0x103a7913 fold_non_dependent_expr_template
        /home/seurer/gcc/git/gcc-test/gcc/cp/constexpr.cc:8172
0x10636ea3 build_non_dependent_expr(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:28647
0x106379a3 make_args_non_dependent(vec<tree_node*, va_gc, vl_embed>*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:28729
0x1033ea53 build_new_method_call(tree_node*, tree_node*, vec<tree_node*, va_gc,
vl_embed>**, tree_node*, int, tree_node**, int)
        /home/seurer/gcc/git/gcc-test/gcc/cp/call.cc:10939
0x105d91e7 cp_parser_postfix_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:7856
0x105fddd3 cp_parser_unary_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:9037
0x105b0307 cp_parser_cast_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:9941
0x105b0e83 cp_parser_binary_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:10043
0x105b1aff cp_parser_assignment_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:10347
0x105b5d33 cp_parser_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:10517
0x105ba46b cp_parser_expression_statement
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:12734
0x105d22ff cp_parser_statement
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:12526
0x105d3803 cp_parser_statement_seq_opt
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:12883
0x105d3957 cp_parser_compound_statement
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:12835
0x1060f613 cp_parser_function_body
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:25186

[Bug c++/105803] [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
I still cannot reproduce with
GNU C++17 (GCC) version 13.0.0 20220530 (experimental)
(powerpc64le-unknown-linux-gnu)

Can you please double check that the Comment 2 test is the correct one?

[Bug c++/105803] [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

--- Comment #4 from seurer at gcc dot gnu.org ---
Yes it is:

seurer@muskie:~/gcc/cpu2017/benchspec/CPU/510.parest_r/build/build_peak_none.0002$
whichgcc
Now at commit ff91735a5b861dd6eaf2c1e511f26a9255898e7d, r13-860-gff91735a5b861d 

seurer@muskie:~/gcc/cpu2017/benchspec/CPU/510.parest_r/build/build_peak_none.0002$
cat test.cc

#include <vector>
#include <memory>

class SparsityPattern
{
  public:
};

template <class SparsityPatternBase>
class BlockSparsityPatternBase// : public Subscriptor
{
};

class BlockSparsityPattern :  public BlockSparsityPatternBase<SparsityPattern>
{
};


class MGTransferBlockBase
{
  public:
    std::vector<std::shared_ptr<BlockSparsityPattern> >
prolongation_sparsities;
    template <int dim, int spacedim>
    void build_matrices ();
};

template <int dim, int spacedim>
void MGTransferBlockBase::build_matrices ()
{
  prolongation_sparsities.push_back (std::shared_ptr<BlockSparsityPattern> (new
BlockSparsityPattern));
}

seurer@muskie:~/gcc/cpu2017/benchspec/CPU/510.parest_r/build/build_peak_none.0002$
/home/seurer/gcc/git/install/gcc-test/bin/g++ -c test.cc
test.cc: In member function 'void MGTransferBlockBase::build_matrices()':
test.cc:31:37: internal compiler error: in type_dependent_expression_p, at
cp/pt.cc:27737
   31 |   prolongation_sparsities.push_back
(std::shared_ptr<BlockSparsityPattern> (new BlockSparsityPattern));
      |  
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
0x1063cb33 type_dependent_expression_p(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:27737
0x1063d6f3 value_dependent_expression_p(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:27465
0x1063df77 value_dependent_expression_p(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:27707
0x106447cf any_value_dependent_elements_p(tree_node const*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:28184
0x103a7257 is_nondependent_constant_expression(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/constexpr.cc:9673
0x103a7913 fold_non_dependent_expr_template
        /home/seurer/gcc/git/gcc-test/gcc/cp/constexpr.cc:8172
0x10636ea3 build_non_dependent_expr(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:28647
0x106379a3 make_args_non_dependent(vec<tree_node*, va_gc, vl_embed>*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.cc:28729
0x1033ea53 build_new_method_call(tree_node*, tree_node*, vec<tree_node*, va_gc,
vl_embed>**, tree_node*, int, tree_node**, int)
        /home/seurer/gcc/git/gcc-test/gcc/cp/call.cc:10939
0x105d91e7 cp_parser_postfix_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:7856
0x105fddd3 cp_parser_unary_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:9037
0x105b0307 cp_parser_cast_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:9941
0x105b0e83 cp_parser_binary_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:10043
0x105b1aff cp_parser_assignment_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:10347
0x105b5d33 cp_parser_expression
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:10517
0x105ba46b cp_parser_expression_statement
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:12734
0x105d22ff cp_parser_statement
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:12526
0x105d3803 cp_parser_statement_seq_opt
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:12883
0x105d3957 cp_parser_compound_statement
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:12835
0x1060f613 cp_parser_function_body
        /home/seurer/gcc/git/gcc-test/gcc/cp/parser.cc:25186

[Bug c++/105803] [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

--- Comment #5 from seurer at gcc dot gnu.org ---
And it was that revision, too.

seurer@muskie:~/gcc/git/build/gcc-test$ whichgcc
Now at commit 1ad584d538d349db13cfa8440222d91d5e9aff3f, r13-859-g1ad584d538d349 


seurer@muskie:~/gcc/cpu2017/benchspec/CPU/510.parest_r/build/build_peak_none.0002$
/home/seurer/gcc/git/install/gcc-test/bin/g++ -c test.cc
seurer@muskie:~/gcc/cpu2017/benchspec/CPU/510.parest_r/build/build_peak_none.0002$

[Bug c++/105803] [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

--- Comment #6 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Weird.  Can you show your gcc -v output so that I can configure gcc the same? 
(Yes, checking is enabled in my build.)

[Bug c++/105803] [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0
           Keywords|                            |ice-on-valid-code
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-06-01

--- Comment #7 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Ah, never mind, I can reproduce with -fchecking=2.

[Bug c++/105803] [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

--- Comment #8 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Reduced:

namespace std {
template <typename> class shared_ptr;
}
struct S {};
template <int> void build_matrices() {
  std::shared_ptr<S>(new S);
}

[Bug c++/105803] [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

--- Comment #9 from Hongtao.liu <crazylht at gmail dot com> ---
Similar error observed for x86 on ICX.
With option `-march=icx -Ofast -flto` for 510.parest_r.

[Bug c++/105803] [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

--- Comment #10 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Hongtao.liu from comment #9)
> Similar error observed for x86 on ICX.
> With option `-march=icx -Ofast -flto` for 510.parest_r.

-march=icelake-server

[Bug c++/105803] [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:7b98910406b5000a6429c188b0c6cc14e3140637

commit r13-968-g7b98910406b5000a6429c188b0c6cc14e3140637
Author: Marek Polacek <polacek@redhat.com>
Date:   Wed Jun 1 18:21:36 2022 -0400

    c++: ICE with template NEW_EXPR [PR105803]

    Here we ICE because value_dependent_expression_p gets a NEW_EXPR
    whose operand is a type, and we go to the default case which just
    calls v_d_e_p on each operand of the NEW_EXPR.  Since one of them
    is a type, we crash on the new assert in t_d_e_p.

    t_d_e_p has code to handle {,VEC_}NEW_EXPR, which at this point
    was already performed, so I think we can handle these two codes
    specifically and skip the second operand, which is always going
    to be a type.

            PR c++/105803

    gcc/cp/ChangeLog:

            * pt.cc (value_dependent_expression_p): Handle {,VEC_}NEW_EXPR
            in the switch.

    gcc/testsuite/ChangeLog:

            * g++.dg/template/new13.C: New test.

[Bug c++/105803] [13 regression] ICE at gcc/cp/pt.cc:27737 after r13-860-gff91735a5b861d

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105803

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Should be fixed.  Please reopen if there still are ICEs.