From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id D8A6B384B0C9; Wed, 1 Jun 2022 21:31:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D8A6B384B0C9 From: "unlvsur at live dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/105810] New: __glibcxx_assert can be improved greatly. Date: Wed, 01 Jun 2022 21:31:28 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libstdc++ X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: unlvsur at live dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2022 21:31:29 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105810 Bug ID: 105810 Summary: __glibcxx_assert can be improved greatly. Product: gcc Version: 13.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: libstdc++ Assignee: unassigned at gcc dot gnu.org Reporter: unlvsur at live dot com Target Milestone: --- Every function call has to carry the call which adds a burden. With -Os the function does not even get expanded. The operator[] becomes extremely expensive. https://godbolt.org/z/Gcchdrdxj The situation might get worse when compiling with -fPIC since load/store da= ta from %rip register needs more instructions. It can be improved to something like this. Put all the file, line, and condition information into a separate function. Since the function is an in= line function, the entire program only holds one copy of the debugging informati= on. https://godbolt.org/z/xc8jnqh5r https://godbolt.org/z/85M1PE9Te vs https://godbolt.org/z/6fsGo41bj Unfortunately, GCC got ICE. I have submitted the bug report to fix that. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105809=