From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 414DC3858410; Thu,  2 Mar 2023 08:07:10 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 414DC3858410
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1677744430;
	bh=N99at10ymhnE0n4E7rxQKejz+Tv4nQoI7WhawTGs/Ms=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=bidmqbYNGomDFpQg0qbPF/onKxIvYJ7bbv+aRFXQa16QDkZo/D/QPxC2Qdq5PmDTF
	 eGNI1jJCMKIrp+UZaIYY0wUwyjz6jQ2ZY18rYvdenOpl+xKyQtv7FYHHfqQGO+slXO
	 Emi9BJCvmF1pz2OGf1lutY8kdzR5TDeTZUyptnP8=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/105839] internal compiler error: in tsubst_omp_for_iterator
 with openmp and structured bindings in a template
Date: Thu, 02 Mar 2023 08:07:09 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 12.1.0
X-Bugzilla-Keywords: openmp
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-105839-4-5AoBpQVbtD@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-105839-4@http.gcc.gnu.org/bugzilla/>
References: <bug-105839-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105839

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:f0ef740d54f47ff614eb02e13e8f4cb11dfbb140

commit r13-6407-gf0ef740d54f47ff614eb02e13e8f4cb11dfbb140
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Mar 2 09:02:12 2023 +0100

    openmp: Fix up error recovery for invalid structured bindings in OpenMP
range for loops [PR105839]

    The PR108503 temporary DECL_HAS_VALUE_EXPR_P clearing code can ICE
    during recovery, because cp_finish_decomp when it detects errors and
    reports them clears DECL_HAS_VALUE_EXPR_P, clears DECL_VALUE_EXPR and
    sets TREE_TYPE of the structured binding vars to error_mark_node.
    The PR108503 code had an assertion that DECL_HAS_VALUE_EXPR_P is set
    so that it can clear it and restore later.

    The following patch allows DECL_HAS_VALUE_EXPR_P to be unset if
    type is error_mark_node and doesn't set it again in that case.

    2023-03-02  Jakub Jelinek  <jakub@redhat.com>

            PR c++/105839
            * parser.cc (cp_convert_omp_range_for): Allow in assert
            decomp_first_name without DECL_HAS_VALUE_EXPR_P if it has
            error_mark_node type.
            (cp_finish_omp_range_for): Don't set DECL_HAS_VALUE_EXPR_P back
            on decls which have error_mark_node type.

            * g++.dg/gomp/pr105839-1.C: New test.
            * g++.dg/gomp/pr105839-2.C: New test.=