From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 6782D38418B8; Mon,  6 Jun 2022 15:19:45 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6782D38418B8
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/105844] [10/11/12/13 Regression] std::lcm(50000,
 49999) is UB but accepted in a constexpr due to cast to unsigned
Date: Mon, 06 Jun 2022 15:19:45 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 12.1.0
X-Bugzilla-Keywords: accepts-invalid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: redi at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-105844-4-5OHapVPxry@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-105844-4@http.gcc.gnu.org/bugzilla/>
References: <bug-105844-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jun 2022 15:19:45 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105844

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I think the fix we want is simply:

--- a/libstdc++-v3/include/std/numeric
+++ b/libstdc++-v3/include/std/numeric
@@ -68,6 +68,7 @@
 #if __cplusplus >=3D 201402L
 # include <type_traits>
 # include <bit>
+# include <ext/numeric_traits.h>
 #endif

 #if __cplusplus >=3D 201703L
@@ -102,7 +103,15 @@ namespace __detail
       static_assert(is_unsigned<_Up>::value, "result type must be unsigned=
");
       static_assert(sizeof(_Up) >=3D sizeof(_Tp),
          "result type must be at least as wide as the input type");
-      return __val < 0 ? -(_Up)__val : (_Up)__val;
+
+      if (__val >=3D 0)
+       return static_cast<_Up>(__val);
+
+      if _GLIBCXX17_CONSTEXPR (sizeof(_Up) =3D=3D sizeof(_Tp))
+       {
+         __glibcxx_assert(__val !=3D __gnu_cxx::__int_traits<_Tp>::__min);
+       }
+      return -static_cast<_Up>(__val);
     }

   template<typename _Up> void __absu(bool) =3D delete;=