public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/105854] ICE: in extract_constrain_insn, at recog.cc:2692 (insn does not satisfy its constraints: sse2_lshrv1ti3)
Date: Tue, 05 Jul 2022 17:02:01 +0000	[thread overview]
Message-ID: <bug-105854-4-2QKAXxaIDN@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105854-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105854

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Roger Sayle <sayle@gcc.gnu.org>:

https://gcc.gnu.org/g:02e2e15ec4b610c0f5c73e1db424b1bbc65dd39a

commit r13-1508-g02e2e15ec4b610c0f5c73e1db424b1bbc65dd39a
Author: Roger Sayle <roger@nextmovesoftware.com>
Date:   Tue Jul 5 18:00:00 2022 +0100

    UNSPEC_PALIGNR optimizations and clean-ups on x86.

    This patch is a follow-up to Hongtao's fix for PR target/105854.  That
    fix is perfectly correct, but the thing that caught my eye was why is
    the compiler generating a shift by zero at all.  Digging deeper it
    turns out that we can easily optimize __builtin_ia32_palignr for
    alignments of 0 and 64 respectively, which may be simplified to moves
    of the highpart and lowpart respectively.

    After adding optimizations to simplify the 64-bit DImode palignr, I
    started to add the corresponding optimizations for vpalignr (i.e.
    128-bit).  The first oddity is that sse.md uses TImode and a special
    SSESCALARMODE iterator, rather than V1TImode, and indeed the comment
    above SSESCALARMODE hints that this should be "dropped in favor of
    VIMAX_AVX2_AVX512BW".  Hence this patch includes the migration of
    <ssse3_avx2>_palignr<mode> to use VIMAX_AVX2_AVX512BW, basically
    using V1TImode instead of TImode for 128-bit palignr.

    This patch has been tested on x86_64-pc-linux-gnu with make bootstrap
    and make -k check, both with and without --target_board=unix{-,32},
    with no new failures.  Ok for mainline?

    2022-07-05  Roger Sayle  <roger@nextmovesoftware.com>
                Hongtao Liu  <hongtao.liu@intel.com>

    gcc/ChangeLog
            * config/i386/i386-builtin.def (__builtin_ia32_palignr128): Change
            CODE_FOR_ssse3_palignrti to CODE_FOR_ssse3_palignrv1ti.
            * config/i386/i386-expand.cc (expand_vec_perm_palignr): Use
V1TImode
            and gen_ssse3_palignv1ti instead of TImode.
            * config/i386/sse.md (SSESCALARMODE): Delete.
            (define_mode_attr ssse3_avx2): Handle V1TImode instead of TImode.
            (<ssse3_avx2>_palignr<mode>): Use VIMAX_AVX2_AVX512BW as a mode
            iterator instead of SSESCALARMODE.
            (ssse3_palignrdi): Optimize cases where operands[3] is 0 or 64,
            using a single move instruction (if required).

    gcc/testsuite/ChangeLog
            * gcc.target/i386/ssse3-palignr-2.c: New test case.

  parent reply	other threads:[~2022-07-05 17:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-05  9:28 [Bug target/105854] New: " zsojka at seznam dot cz
2022-06-06  3:47 ` [Bug target/105854] " crazylht at gmail dot com
2022-06-07  9:32 ` cvs-commit at gcc dot gnu.org
2022-06-08  2:59 ` cvs-commit at gcc dot gnu.org
2022-06-08  3:17 ` cvs-commit at gcc dot gnu.org
2022-06-08  3:17 ` cvs-commit at gcc dot gnu.org
2022-06-08  3:18 ` crazylht at gmail dot com
2022-07-05 17:02 ` cvs-commit at gcc dot gnu.org [this message]
2022-07-06 13:52 ` roger at nextmovesoftware dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105854-4-2QKAXxaIDN@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).