[Bug rust/105913] New: gccrs doesn't compile on 32-bit targets

[Bug rust/105913] New: gccrs doesn't compile on 32-bit targets

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105913

            Bug ID: 105913
           Summary: gccrs doesn't compile on 32-bit targets
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rust
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
  Target Milestone: ---
            Target: i386-pc-solaris2.11, i686-pc-linux-gnu

Created attachment 53115
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53115&action=edit
hacky patch

I recently tried bootstrapping the devel/rust/master branch as of
9d81164aa0447c738fe0435de14ec9666a03d5da
on Solaris/x86 and Linux/i686, but unlike Linux/x86_64 the build failed for
several instances of the same issue:

/vol/gcc/src/git/rust/gcc/rust/lex/rust-lex.cc: In member function
'std::pair<Rust::Codepoint, int> Rust::Lexer::parse_partial_unicode_escape()':
/vol/gcc/src/git/rust/gcc/rust/lex/rust-lex.cc:1574:43: error: format '%lu'
expects argument of type 'long unsigned int', but argument 3 has type
'std::__cxx11::basic_string<char>::size_type' {aka 'unsigned int'}
[-Werror=format=]
 1574 |                      "characters; it is %lu",
      |                                         ~~^
      |                                           |
      |                                           long unsigned int
      |                                         %u
 1575 |                      num_str.length ());
      |                      ~~~~~~~~~~~~~~~~~
      |                                     |
      |                                    
std::__cxx11::basic_string<char>::size_type {aka unsigned int}

It's always trying to print size_t (unsigned int) with a %ld or %lu format.

The attached hacky patch casts the arguments accordingly, and allows the
bootstrap
to finish and the testsuite (both 32 and 64-bit) to run successfully.

[Bug rust/105913] gccrs doesn't compile on 32-bit targets

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105913

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> ---
Also known as gccrs Issue #1229.

[Bug rust/105913] gccrs doesn't compile on 32-bit targets

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105913

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|13.0                        |rust/master
           See Also|                            |https://github.com/Rust-GCC
                   |                            |/gccrs/issues/1229
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-06-10
             Status|UNCONFIRMED                 |NEW
                 CC|                            |tschwinge at gcc dot gnu.org

[Bug rust/105913] gccrs doesn't compile on 32-bit targets

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105913

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |dkm at gcc dot gnu.org
           See Also|                            |https://github.com/Rust-GCC
                   |                            |/gccrs/pull/1308

[Bug rust/105913] gccrs doesn't compile on 32-bit targets

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105913

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Assuming fixed via <https://github.com/Rust-GCC/gccrs/pull/1308> "Fix
formatting error on 32-bits targets".

[Bug rust/105913] gccrs doesn't compile on 32-bit targets

[dkm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105913

--- Comment #3 from Marc Poulhiès <dkm at gcc dot gnu.org> ---
Fixed in github, but not yet in gcc's repository AFAIK.

[Bug rust/105913] gccrs doesn't compile on 32-bit targets

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105913

--- Comment #4 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
(In reply to Marc Poulhiès from comment #3)
> Fixed in github, but not yet in gcc's repository AFAIK.

It is, as of today, 10:33 UTC, when I did the 'git push'.  ;-).


(If there's more to do, then please re-open this PR, of course.)

[Bug rust/105913] gccrs doesn't compile on 32-bit targets

[dkm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105913

--- Comment #5 from Marc Poulhiès <dkm at gcc dot gnu.org> ---
Oh, nice, should have checked before commenting then ! Thanks !

[Bug rust/105913] gccrs doesn't compile on 32-bit targets

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105913

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> ---
Unfortunately, after I created my original patch, another instance of the same
issue crept in: reported upstream with an incremental patch.

[Bug rust/105913] gccrs doesn't compile on 32-bit targets

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105913

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #7 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
But now really assuming fixed via additional
<https://github.com/Rust-GCC/gccrs/pull/1331> "Fix remaining misuses of format
specifiers on 32-bit targets".

[Bug rust/105913] gccrs doesn't compile on 32-bit targets

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105913

--- Comment #8 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #7 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
> But now really assuming fixed via additional
> <https://github.com/Rust-GCC/gccrs/pull/1331> "Fix remaining misuses of format
> specifiers on 32-bit targets".

Now confirmed on both i386-pc-solaris2.11 and sparc-sun-solaris2.11
(which needs the hack from PR c++/106072).