public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/105940] suggested_unroll_factor applying place looks wrong Date: Thu, 23 Jun 2022 02:25:22 +0000 [thread overview] Message-ID: <bug-105940-4-PxU5U2Tdkr@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-105940-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105940 --- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-12 branch has been updated by Kewen Lin <linkw@gcc.gnu.org>: https://gcc.gnu.org/g:bb1a6d92989a50df13b1a21085c86625089c9e53 commit r12-8505-gbb1a6d92989a50df13b1a21085c86625089c9e53 Author: Richard Sandiford <richard.sandiford@arm.com> Date: Wed Jun 15 11:12:51 2022 +0100 aarch64: Revert bogus fix for PR105254 In f2ebf2d98efe0ac2314b58cf474f44cb8ebd5244 I'd forced the chosen unroll factor to be a factor of the VF, in order to work around an exact_div ICE in PR105254. This was completely bogus -- clearly I didn't look in enough detail at why we ended up with an unrolled VF that wasn't a multiple of the UF. Kewen has since fixed the bug properly for PR105940, so this patch reverts my earlier attempt. Sorry for the stupidity. gcc/ PR tree-optimization/105254 PR tree-optimization/105940 Revert: * config/aarch64/aarch64.cc (aarch64_vector_costs::determine_suggested_unroll_factor): Take a loop_vec_info as argument. Restrict the unroll factor to values that divide the VF. (aarch64_vector_costs::finish_cost): Update call accordingly. gcc/testsuite/ * gcc.target/aarch64/sve/cost_model_14.c: New test. (cherry picked from commit 2636660b6f35423e0cfbf53bfad5c5fed6ae6471)
next prev parent reply other threads:[~2022-06-23 2:25 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-13 5:59 [Bug tree-optimization/105940] New: " linkw at gcc dot gnu.org 2022-06-13 6:07 ` [Bug tree-optimization/105940] " linkw at gcc dot gnu.org 2022-06-13 6:08 ` linkw at gcc dot gnu.org 2022-06-13 8:25 ` rguenth at gcc dot gnu.org 2022-06-14 5:58 ` cvs-commit at gcc dot gnu.org 2022-06-14 8:46 ` linkw at gcc dot gnu.org 2022-06-15 10:13 ` cvs-commit at gcc dot gnu.org 2022-06-16 13:33 ` linkw at gcc dot gnu.org 2022-06-16 13:35 ` linkw at gcc dot gnu.org 2022-06-17 10:56 ` linkw at gcc dot gnu.org 2022-06-20 12:45 ` cvs-commit at gcc dot gnu.org 2022-06-23 1:59 ` cvs-commit at gcc dot gnu.org 2022-06-23 2:25 ` cvs-commit at gcc dot gnu.org [this message] 2022-06-23 3:20 ` linkw at gcc dot gnu.org 2022-06-23 6:28 ` rguenther at suse dot de
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-105940-4-PxU5U2Tdkr@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).