public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/105965] [10/11/12/13 Regression] x86: single-element vectors don't have scalar FMA insns used anymore
Date: Tue, 14 Jun 2022 08:40:03 +0000	[thread overview]
Message-ID: <bug-105965-4-98sm3baonw@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105965-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105965

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
   Target Milestone|---                         |10.4
           Priority|P3                          |P2
             Status|UNCONFIRMED                 |ASSIGNED
            Summary|x86: single-element vectors |[10/11/12/13 Regression]
                   |don't have scalar FMA insns |x86: single-element vectors
                   |used anymore                |don't have scalar FMA insns
                   |                            |used anymore
   Last reconfirmed|                            |2022-06-14
     Ever confirmed|0                           |1
           Keywords|                            |missed-optimization

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
The widen-mul pass now sees

  <bb 2> [local count: 1073741824]:
  _8 = VIEW_CONVERT_EXPR<float>(a_3(D));
  _9 = VIEW_CONVERT_EXPR<float>(b_4(D));
  _10 = _8 * _9;
  _1 = {_10};
  _11 = VIEW_CONVERT_EXPR<float>(_1);
  _12 = VIEW_CONVERT_EXPR<float>(c_5(D));
  _13 = _11 + _12;
  BIT_FIELD_REF <<retval>, 32, 0> = _13;
  return <retval>;

which confuses it.  The above is the result from vector lowering which
presumably
sees that V1SFmode isn't supported.  In GCC 8 the above is instead

  <bb 2> [local count: 1073741825]:
  _8 = BIT_FIELD_REF <a_3(D), 32, 0>;
  _9 = BIT_FIELD_REF <b_4(D), 32, 0>;
  _10 = _8 * _9;
  _11 = BIT_FIELD_REF <c_5(D), 32, 0>;
  _12 = _10 + _11;
  _2 = {_12};
  <retval> = _2;

that means we are at least missing a match.pd pattern to simplify

  _1 = {_10};
  _11 = VIEW_CONVERT_EXPR<float>(_1);

  parent reply	other threads:[~2022-06-14  8:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  6:31 [Bug target/105965] New: " jbeulich at suse dot com
2022-06-14  8:23 ` [Bug target/105965] " crazylht at gmail dot com
2022-06-14  8:40 ` rguenth at gcc dot gnu.org [this message]
2022-06-14 10:53 ` [Bug target/105965] [10/11/12/13 Regression] " cvs-commit at gcc dot gnu.org
2022-06-14 10:53 ` [Bug target/105965] [10/11/12 " rguenth at gcc dot gnu.org
2022-06-21  1:52 ` [Bug tree-optimization/105965] " pinskia at gcc dot gnu.org
2022-06-21  6:59 ` rguenther at suse dot de
2022-06-28 10:49 ` jakub at gcc dot gnu.org
2022-07-19 11:38 ` cvs-commit at gcc dot gnu.org
2022-07-19 11:39 ` [Bug tree-optimization/105965] [10/11 " rguenth at gcc dot gnu.org
2023-07-07 10:43 ` [Bug tree-optimization/105965] [11 " rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105965-4-98sm3baonw@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).