[Bug c/105970] New: ICE in ix86_function_arg, at config/i386/i386.cc:3351

[Bug c/105970] New: ICE in ix86_function_arg, at config/i386/i386.cc:3351

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105970

            Bug ID: 105970
           Summary: ICE in ix86_function_arg, at config/i386/i386.cc:3351
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to r7, with files gcc.dg/torture/pr68037-*.c :


$ gcc-13-20220612 -c pr68037-1.c -mx32 -mgeneral-regs-only
$
$ gcc-13-20220612 -c pr68037-1.c -mx32 -mgeneral-regs-only -maddress-mode=long
during RTL pass: expand
pr68037-1.c: In function 'fn':
pr68037-1.c:32:1: internal compiler error: in ix86_function_arg, at
config/i386/i386.cc:3351
   32 | fn (struct interrupt_frame *frame, uword_t error)
      | ^~
0xf2c309 ix86_function_arg
        ../../gcc/config/i386/i386.cc:3351
0x9313c8 assign_parm_find_entry_rtl
        ../../gcc/function.cc:2535
0x9313c8 assign_parms
        ../../gcc/function.cc:3673
0x933607 expand_function_start(tree_node*)
        ../../gcc/function.cc:5161
0x7d7c21 execute
        ../../gcc/cfgexpand.cc:6695

[Bug c/105970] ICE in ix86_function_arg, at config/i386/i386.cc:3351

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105970

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-06-14
                 CC|                            |hjl.tools at gmail dot com
     Ever confirmed|0                           |1

--- Comment #1 from Uroš Bizjak <ubizjak at gmail dot com> ---
Probably something like:

diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
index 3d189e124e4..f158cc3aaea 100644
--- a/gcc/config/i386/i386.cc
+++ b/gcc/config/i386/i386.cc
@@ -3348,7 +3348,7 @@ ix86_function_arg (cumulative_args_t cum_v, const
function_arg_info &arg)
       if (POINTER_TYPE_P (arg.type))
        {
          /* This is the pointer argument.  */
-         gcc_assert (TYPE_MODE (arg.type) == Pmode);
+         gcc_assert (TYPE_MODE (arg.type) == ptr_mode);
          /* It is at -WORD(AP) in the current frame in interrupt and
             exception handlers.  */
          reg = plus_constant (Pmode, arg_pointer_rtx, -UNITS_PER_WORD);

Pointer mode and Pmode can be distinct for x32 target.  However, I have no idea
what goes into interrupt frame for x32. Let's ask HJ.

[Bug c/105970] ICE in ix86_function_arg, at config/i386/i386.cc:3351

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105970

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Uroš Bizjak from comment #1)
> Probably something like:
> 
> diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
> index 3d189e124e4..f158cc3aaea 100644
> --- a/gcc/config/i386/i386.cc
> +++ b/gcc/config/i386/i386.cc
> @@ -3348,7 +3348,7 @@ ix86_function_arg (cumulative_args_t cum_v, const
> function_arg_info &arg)
>        if (POINTER_TYPE_P (arg.type))
>         {
>           /* This is the pointer argument.  */
> -         gcc_assert (TYPE_MODE (arg.type) == Pmode);
> +         gcc_assert (TYPE_MODE (arg.type) == ptr_mode);

This looks reasonable since pointer mode should be ptr_mode.

>           /* It is at -WORD(AP) in the current frame in interrupt and
>              exception handlers.  */
>           reg = plus_constant (Pmode, arg_pointer_rtx, -UNITS_PER_WORD);
> 
> Pointer mode and Pmode can be distinct for x32 target.  However, I have no
> idea what goes into interrupt frame for x32. Let's ask HJ.

[Bug c/105970] ICE in ix86_function_arg, at config/i386/i386.cc:3351

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105970

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Uros Bizjak <uros@gcc.gnu.org>:

https://gcc.gnu.org/g:1f8278bfcfc7f7157bf2b405471e67dd5097636b

commit r13-1156-g1f8278bfcfc7f7157bf2b405471e67dd5097636b
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Fri Jun 17 17:01:31 2022 +0200

    i386: Fix assert in ix86_function_arg [PR105970]

    The mode of pointer argument should equal ptr_mode, not Pmode.

    2022-06-17  Uroš Bizjak  <ubizjak@gmail.com>

    gcc/ChangeLog:

            PR target/105970
            * config/i386/i386.cc (ix86_function_arg): Assert that
            the mode of pointer argumet is equal to ptr_mode, not Pmode.

    gcc/testsuite/ChangeLog:

            PR target/105970
            * gcc.target/i386/pr105970.c: New test.

[Bug c/105970] ICE in ix86_function_arg, at config/i386/i386.cc:3351

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105970

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Uros Bizjak <uros@gcc.gnu.org>:

https://gcc.gnu.org/g:ddc9b963ab9f267e8cc54be1fa6fcca2e8b0eb84

commit r12-8498-gddc9b963ab9f267e8cc54be1fa6fcca2e8b0eb84
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Fri Jun 17 17:01:31 2022 +0200

    i386: Fix assert in ix86_function_arg [PR105970]

    The mode of pointer argument should equal ptr_mode, not Pmode.

    2022-06-17  Uroš Bizjak  <ubizjak@gmail.com>

    gcc/ChangeLog:

            PR target/105970
            * config/i386/i386.cc (ix86_function_arg): Assert that
            the mode of pointer argumet is equal to ptr_mode, not Pmode.

    gcc/testsuite/ChangeLog:

            PR target/105970
            * gcc.target/i386/pr105970.c: New test.

    (cherry picked from commit 1f8278bfcfc7f7157bf2b405471e67dd5097636b)

[Bug c/105970] ICE in ix86_function_arg, at config/i386/i386.cc:3351

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105970

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Uros Bizjak <uros@gcc.gnu.org>:

https://gcc.gnu.org/g:84fe5ace4734cb0eeb342114e744455a7178b0e2

commit r11-10082-g84fe5ace4734cb0eeb342114e744455a7178b0e2
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Fri Jun 17 17:01:31 2022 +0200

    i386: Fix assert in ix86_function_arg [PR105970]

    The mode of pointer argument should equal ptr_mode, not Pmode.

    2022-06-17  Uroš Bizjak  <ubizjak@gmail.com>

    gcc/ChangeLog:

            PR target/105970
            * config/i386/i386.c (ix86_function_arg): Assert that
            the mode of pointer argumet is equal to ptr_mode, not Pmode.

    gcc/testsuite/ChangeLog:

            PR target/105970
            * gcc.target/i386/pr105970.c: New test.

    (cherry picked from commit 1f8278bfcfc7f7157bf2b405471e67dd5097636b)

[Bug c/105970] ICE in ix86_function_arg, at config/i386/i386.cc:3351

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105970

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Uros Bizjak <uros@gcc.gnu.org>:

https://gcc.gnu.org/g:570a6067ff6928fe76bb13cece38346d9a966a13

commit r10-10860-g570a6067ff6928fe76bb13cece38346d9a966a13
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Fri Jun 17 17:01:31 2022 +0200

    i386: Fix assert in ix86_function_arg [PR105970]

    The mode of pointer argument should equal ptr_mode, not Pmode.

    2022-06-17  Uroš Bizjak  <ubizjak@gmail.com>

    gcc/ChangeLog:

            PR target/105970
            * config/i386/i386.c (ix86_function_arg): Assert that
            the mode of pointer argumet is equal to ptr_mode, not Pmode.

    gcc/testsuite/ChangeLog:

            PR target/105970
            * gcc.target/i386/pr105970.c: New test.

    (cherry picked from commit 1f8278bfcfc7f7157bf2b405471e67dd5097636b)

[Bug target/105970] ICE in ix86_function_arg, at config/i386/i386.cc:3351

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105970

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |10.4
          Component|c                           |target
         Resolution|---                         |FIXED

--- Comment #7 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed for gcc-10.4+