[Bug target/105974] New: [13 Regression] ICE: RTL check: expected elt 0 type 'i' or 'n', have 'w' (rtx const_int) in arm_bfi_1_p, at config/arm/arm.cc:10214

[Bug target/105974] New: [13 Regression] ICE: RTL check: expected elt 0 type 'i' or 'n', have 'w' (rtx const_int) in arm_bfi_1_p, at config/arm/arm.cc:10214

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105974

            Bug ID: 105974
           Summary: [13 Regression] ICE: RTL check: expected elt 0 type
                    'i' or 'n', have 'w' (rtx const_int) in arm_bfi_1_p,
                    at config/arm/arm.cc:10214
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: build, ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: armv7a-hardfloat-linux-gnueabi

Created attachment 53134
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53134&action=edit
reduced testcase

This currently breaks build with RTL checking enabled.

Compiler output:
$ /repo/build-gcc-trunk-armv7a-hardfloat/./gcc/cc1 -O2 -march=armv7-a+vfpv4
testcase.c 
 __gnu_fractqquda
Analyzing compilation unit
Performing interprocedural optimizations
 <*free_lang_data> {heap 932k} <visibility> {heap 932k} <build_ssa_passes>
{heap 932k} <opt_local_passes> {heap 1212k} <remove_symbols> {heap 1684k}
<targetclone> {heap 1684k} <free-fnsummary> {heap 1684k} <increase_alignment>
{heap 1684k}Streaming LTO
 <whole-program> {heap 1684k} <profile_estimate> {heap 1684k} <icf> {heap
1684k} <devirt> {heap 1684k} <cp> {heap 1684k} <sra> {heap 1684k} <fnsummary>
{heap 1684k} <inline> {heap 1684k} <pure-const> {heap 1684k} <modref> {heap
1684k} <free-fnsummary> {heap 1684k} <static-var> {heap 1684k} <single-use>
{heap 1684k} <comdats> {heap 1684k}Assembling functions:
 __gnu_fractqqudaduring RTL pass: combine

testcase.c: In function '__gnu_fractqquda':
testcase.c:9:1: internal compiler error: RTL check: expected elt 0 type 'i' or
'n', have 'w' (rtx const_int) in arm_bfi_1_p, at config/arm/arm.cc:10214
    9 | }
      | ^
0x71d11e rtl_check_failed_type2(rtx_def const*, int, int, int, char const*,
int, char const*)
        /repo/gcc-trunk/gcc/rtl.cc:907
0x7d01d3 arm_bfi_1_p
        /repo/gcc-trunk/gcc/config/arm/arm.cc:10214
0x14406d6 arm_bfi_p
        /repo/gcc-trunk/gcc/config/arm/arm.cc:10255
0x14406d6 arm_rtx_costs_internal
        /repo/gcc-trunk/gcc/config/arm/arm.cc:11027
0x14406d6 arm_rtx_costs
        /repo/gcc-trunk/gcc/config/arm/arm.cc:12058
0x102c33e rtx_cost(rtx_def*, machine_mode, rtx_code, int, bool)
        /repo/gcc-trunk/gcc/rtlanal.cc:4629
0x1b69e98 set_src_cost
        /repo/gcc-trunk/gcc/rtl.h:2943
0x1b69e98 distribute_and_simplify_rtx
        /repo/gcc-trunk/gcc/combine.cc:10013
0x1b77941 simplify_logical
        /repo/gcc-trunk/gcc/combine.cc:7103
0x1b77941 combine_simplify_rtx
        /repo/gcc-trunk/gcc/combine.cc:6330
0x1b79d19 subst
        /repo/gcc-trunk/gcc/combine.cc:5605
0x1b7d3d7 try_combine
        /repo/gcc-trunk/gcc/combine.cc:3288
0x1b85dd5 combine_instructions
        /repo/gcc-trunk/gcc/combine.cc:1266
0x1b85dd5 rest_of_handle_combine
        /repo/gcc-trunk/gcc/combine.cc:14976
0x1b85dd5 execute
        /repo/gcc-trunk/gcc/combine.cc:15021
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ /repo/build-gcc-trunk-armv7a-hardfloat/./gcc/xgcc -v
Using built-in specs.
COLLECT_GCC=/repo/build-gcc-trunk-armv7a-hardfloat/./gcc/xgcc
Target: armv7a-hardfloat-linux-gnueabi
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl --with-float=hard --with-fpu=vfpv4
--with-arch=armv7-a --with-sysroot=/usr/armv7a-hardfloat-linux-gnueabi
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=armv7a-hardfloat-linux-gnueabi
--with-ld=/usr/bin/armv7a-hardfloat-linux-gnueabi-ld
--with-as=/usr/bin/armv7a-hardfloat-linux-gnueabi-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r13-1089-20220614140553-g8f6c317b3a1-checking-yes-rtl-df-extra-armv7a-hardfloat
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.0.0 20220614 (experimental) (GCC)

[Bug target/105974] [13 Regression] ICE: RTL check: expected elt 0 type 'i' or 'n', have 'w' (rtx const_int) in arm_bfi_1_p, at config/arm/arm.cc:10214

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105974

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug target/105974] [13 Regression] ICE: RTL check: expected elt 0 type 'i' or 'n', have 'w' (rtx const_int) in arm_bfi_1_p, at config/arm/arm.cc:10214

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105974

Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rearnsha at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-06-15

--- Comment #1 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
Mine

[Bug target/105974] [13 Regression] ICE: RTL check: expected elt 0 type 'i' or 'n', have 'w' (rtx const_int) in arm_bfi_1_p, at config/arm/arm.cc:10214

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105974

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Earnshaw <rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:dc8071da0e89eab4935751f3b16745c95cbc0d30

commit r13-1108-gdc8071da0e89eab4935751f3b16745c95cbc0d30
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Wed Jun 15 13:42:23 2022 +0100

    arm: fix thinko in arm_bfi_1_p() [PR105974]

    I clearly wasn't thinking straight when I wrote the arm_bfi_1_p
    function and used XUINT rather than UINTVAL when extracting CONST_INT
    values.  It seemed to work in testing, but was incorrect and failed
    RTL checking.

    Fixed thusly:

    gcc/ChangeLog:

            PR target/105974
            * config/arm/arm.cc (arm_bfi_1_p): Use UINTVAL instead of XUINT.

[Bug target/105974] [13 Regression] ICE: RTL check: expected elt 0 type 'i' or 'n', have 'w' (rtx const_int) in arm_bfi_1_p, at config/arm/arm.cc:10214

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105974

Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
Fixed