From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 7151C3857C4A; Sat,  2 Jul 2022 16:45:28 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7151C3857C4A
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/106003] RFE: -fanalyzer could complain about misuse of
 file-descriptors
Date: Sat, 02 Jul 2022 16:45:28 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: analyzer
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: mir at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106003-4-oTzr9o6kEz@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106003-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106003-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Jul 2022 16:45:28 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106003

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Immad Mir <mir@gcc.gnu.org>:

https://gcc.gnu.org/g:97baacba963c06e3d0e33cde04e7e687671e60e7

commit r13-1404-g97baacba963c06e3d0e33cde04e7e687671e60e7
Author: Immad Mir <mirimmad17@gmail.com>
Date:   Sat Jul 2 22:09:37 2022 +0530

    analyzer: implement five new warnings for misuse of POSIX file descript=
or
APIs [PR106003].

    This patch adds a new state machine to the analyzer for checking usage =
of
POSIX file descriptor
    APIs with five new warnings.

    It adds:
    - check for FD leaks (CWE 775).
    - check for double "close" of a FD (CWE-1341).
    - check for read/write of a closed file descriptor.
    - check whether a file descriptor was used without being checked for
validity.
    - check for read/write of a descriptor opened for just writing/reading.

    gcc/ChangeLog:
            PR analyzer/106003
            * Makefile.in (ANALYZER_OBJS): Add sm-fd.o.
            * doc/invoke.texi:  Add -Wanalyzer-fd-double-close,
-Wanalyzer-fd-leak,
            -Wanalyzer-fd-access-mode-mismatch,
-Wanalyzer-fd-use-without-check,
            -Wanalyzer-fd-use-after-close.

    gcc/analyzer/ChangeLog:
            PR analyzer/106003
            * analyzer.opt (Wanalyzer-fd-leak): New option.
            (Wanalyzer-fd-access-mode-mismatch): New option.
            (Wanalyzer-fd-use-without-check): New option.
            (Wanalyzer-fd-double-close): New option.
            (Wanalyzer-fd-use-after-close): New option.
            * sm.h (make_fd_state_machine): New decl.
            * sm.cc (make_checkers): Call make_fd_state_machine.
            * sm-fd.cc: New file.

    gcc/testsuite/ChangeLog:
            PR analyzer/106003
            * gcc.dg/analyzer/fd-1.c: New test.
            * gcc.dg/analyzer/fd-2.c: New test.
            * gcc.dg/analyzer/fd-3.c: New test.
            * gcc.dg/analyzer/fd-4.c: New test.=