From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id A51693858438; Wed, 26 Jul 2023 12:15:33 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A51693858438
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1690373733;
	bh=cs2dDnH/NacA1aDK0iqk3M4dMGEQxm1kD4z7LDVoozc=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=pstR7JCC9G+12+ciLM8iprQIoDKnd3avMZeK/y5SUTRNbXhB4C5cJ3TgoEw+lSS2j
	 8Vn7oF2y75wGW3HUTPJmWvmgvSq81ZEc0WP0pBcK+VDZ04aGtWMQXyG8ICaOvpj/mP
	 wdEPmcdtGAHknUbCcjj5QsVkDDeH+wEVtjg80NLI=
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/106081] missed vectorization
Date: Wed, 26 Jul 2023 12:15:33 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: rguenther at suse dot de
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106081-4-CLn0JiShs5@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106081-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106081-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106081

--- Comment #15 from rguenther at suse dot de <rguenther at suse dot de> ---
On Wed, 26 Jul 2023, rsandifo at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106081
>=20
> --- Comment #14 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu=
.org> ---
> FWIW, changing:
>=20
>           if (!STMT_VINFO_GROUPED_ACCESS (dr_stmt))
>             continue;
>=20
> to:
>=20
>           if (!STMT_VINFO_GROUPED_ACCESS (dr_stmt))
>             {
>               partition.layout =3D -1;
>               continue;
>             }
>=20
> in start_choosing_layouts fixes it for me.  We can then choose layout 1 f=
or the
> splat.
>=20
> I think these conditions were carried over from the old code.  Without ch=
ecking
> further, I'm not 100% sure what effect relaxing them would have :)

I've added the above condition when introducing the support for splats
recently.  The above change indeed works - I'm going to give it further
testing.=