public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/106081] missed vectorization Date: Wed, 26 Jul 2023 10:52:07 +0000 [thread overview] Message-ID: <bug-106081-4-R463tG1BG2@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106081-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106081 --- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> --- Btw, I see we actually materialize a permute before the splat: t.c:14:24: note: node 0x5b311c0 (max_nunits=1, refcnt=2) vector(2) double t.c:14:24: note: op: VEC_PERM_EXPR t.c:14:24: note: stmt 0 _1 = *k_50; t.c:14:24: note: stmt 1 _1 = *k_50; t.c:14:24: note: stmt 2 _1 = *k_50; t.c:14:24: note: stmt 3 _1 = *k_50; t.c:14:24: note: lane permutation { 0[3] 0[2] 0[1] 0[0] } t.c:14:24: note: children 0x5b30fc0 t.c:14:24: note: node 0x5b30fc0 (max_nunits=2, refcnt=1) vector(2) double t.c:14:24: note: op template: _1 = *k_50; t.c:14:24: note: stmt 0 _1 = *k_50; t.c:14:24: note: stmt 1 _1 = *k_50; t.c:14:24: note: stmt 2 _1 = *k_50; t.c:14:24: note: stmt 3 _1 = *k_50; t.c:14:24: note: load permutation { 0 0 0 0 } this is because vect_optimize_slp_pass::get_result_with_layout doesn't seem to consider load permutations? It's the value-numbering we perform that in the end elides the redundant permute. I have the feeling something doesn't fit together exactly, during materialize () we apply the chosen layout to the partitions, then eliminate redundant permutes but we still end up with get_result_with_layout adding the above permute. I can add the same logic as I've added to change_layout_cost also to get_result_with_layout but as said, it feels like I'm missing something ...
next prev parent reply other threads:[~2023-07-26 10:52 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-24 15:56 [Bug middle-end/106081] New: " hubicka at gcc dot gnu.org 2022-06-24 16:14 ` [Bug middle-end/106081] " hubicka at gcc dot gnu.org 2022-06-26 8:08 ` crazylht at gmail dot com 2022-06-27 9:01 ` marxin at gcc dot gnu.org 2022-06-27 10:38 ` rguenth at gcc dot gnu.org 2022-06-27 14:26 ` hubicka at gcc dot gnu.org 2022-10-24 0:14 ` pinskia at gcc dot gnu.org 2023-06-21 13:45 ` rguenth at gcc dot gnu.org 2023-06-27 7:49 ` rguenth at gcc dot gnu.org 2023-06-27 8:13 ` rguenth at gcc dot gnu.org 2023-06-27 9:10 ` rsandifo at gcc dot gnu.org 2023-06-28 12:15 ` hubicka at gcc dot gnu.org 2023-07-26 9:34 ` rguenth at gcc dot gnu.org 2023-07-26 9:35 ` rguenth at gcc dot gnu.org 2023-07-26 10:01 ` rsandifo at gcc dot gnu.org 2023-07-26 10:32 ` rguenth at gcc dot gnu.org 2023-07-26 10:52 ` rguenth at gcc dot gnu.org [this message] 2023-07-26 11:00 ` rsandifo at gcc dot gnu.org 2023-07-26 11:15 ` rsandifo at gcc dot gnu.org 2023-07-26 12:15 ` rguenther at suse dot de 2023-07-26 13:28 ` cvs-commit at gcc dot gnu.org 2023-07-26 13:28 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106081-4-R463tG1BG2@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).