public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/106099] [13 Regression] ICE in execute_todo, at passes.cc:2134 since r13-1204-gd68d366425369649 Date: Thu, 28 Jul 2022 10:43:21 +0000 [thread overview] Message-ID: <bug-106099-4-gttuHAe62a@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106099-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106099 --- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:f64eb636677d714781b4543f111b1c9239328db6 commit r13-1874-gf64eb636677d714781b4543f111b1c9239328db6 Author: Jakub Jelinek <jakub@redhat.com> Date: Thu Jul 28 12:42:14 2022 +0200 gimple, internal-fn: Add IFN_TRAP and use it for __builtin_unreachable [PR106099] __builtin_unreachable and __ubsan_handle_builtin_unreachable don't use vops, they are marked const/leaf/noreturn/nothrow/cold. But __builtin_trap uses vops, isn't const, just leaf/noreturn/nothrow/cold. This is I believe so that when users explicitly use __builtin_trap in their sources they get stores visible at the trap side. -fsanitize=unreachable -fsanitize-undefined-trap-on-error used to transform __builtin_unreachable to __builtin_trap even in the past, but the sanopt pass has TODO_update_ssa, so it worked fine. Now that gimple_build_builtin_unreachable can build a __builtin_trap call right away, we can run into problems that whenever we need it we would need to either manually or through TODO_update* ensure the vops being updated. Though, as it is originally __builtin_unreachable which is just implemented as trap, I think for this case it is fine to avoid vops. For this the patch introduces IFN_TRAP, which has ECF_* flags like __builtin_unreachable and is expanded as __builtin_trap. 2022-07-28 Jakub Jelinek <jakub@redhat.com> PR tree-optimization/106099 * internal-fn.def (TRAP): New internal fn. * internal-fn.h (expand_TRAP): Declare. * internal-fn.cc (expand_TRAP): Define. * gimple.cc (gimple_build_builtin_unreachable): For BUILT_IN_TRAP, use internal fn rather than builtin. * gcc.dg/ubsan/pr106099.c: New test.
next prev parent reply other threads:[~2022-07-28 10:43 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-27 6:52 [Bug tree-optimization/106099] New: ICE in execute_todo, at passes.cc:2134 asolokha at gmx dot com 2022-06-27 9:04 ` [Bug tree-optimization/106099] " zsojka at seznam dot cz 2022-06-27 9:07 ` [Bug tree-optimization/106099] [13 Regression] ICE in execute_todo, at passes.cc:2134 since r13-1204-gd68d366425369649 marxin at gcc dot gnu.org 2022-06-27 9:18 ` pinskia at gcc dot gnu.org 2022-06-27 10:48 ` rguenth at gcc dot gnu.org 2022-07-04 10:10 ` marxin at gcc dot gnu.org 2022-07-04 10:12 ` marxin at gcc dot gnu.org 2022-07-04 11:35 ` jakub at gcc dot gnu.org 2022-07-04 11:38 ` jakub at gcc dot gnu.org 2022-07-26 10:25 ` jakub at gcc dot gnu.org 2022-07-28 10:43 ` cvs-commit at gcc dot gnu.org [this message] 2022-07-30 8:22 ` zsojka at seznam dot cz 2022-08-26 7:29 ` cvs-commit at gcc dot gnu.org 2022-10-18 13:02 ` jakub at gcc dot gnu.org 2023-01-03 11:23 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106099-4-gttuHAe62a@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).