public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/106112] [10/11/12/13 Regression] wrong code at -Os and above on x86_64-linux-gnu since r10-2711-g3ed01d5408045d80
Date: Tue, 28 Jun 2022 11:54:30 +0000	[thread overview]
Message-ID: <bug-106112-4-K35Fg7D8MR@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106112-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106112

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
  <bb 2> [local count: 1073741824]:
  e.0_1 = e;
  _2 = e.0_1 | 4294967292;
  e = _2;
  d.1_3 = d;
  _4 = (long unsigned int) d.1_3;
-  # RANGE [2147483647, 6442450942] NONZERO 8589934591
+  # RANGE ~[2147483647, 18446744071562067967]
  _10 = _4 + 4294967295;
  _7 = _10 - _2;
  _8 = 18446744073709551615 % _7;
  _9 = (int) _8;
  c = _9;
  _11 = 18446744073709551614 - _2;
-  _13 = d.1_3 + -1;
-  # RANGE ~[2147483647, 18446744071562067967]
-  _14 = (long unsigned int) _13;
-  _15 = _11 % _14;
+  _15 = _11 % _10;

is the key change, replacing (unsigned long)(intvar + -1) with (unsigned
long)intvar + 4294967295

It looks like

  /* For constants simply extend it.  */
  if (TREE_CODE (op) == INTEGER_CST)
    return wide_int_to_tree (wide_type, wi::to_wide (op));

doesn't sign-extend the -1 from int to unsigned log.  Using wi::to_widest
does and fixes the testcase.

  parent reply	other threads:[~2022-06-28 11:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28  9:59 [Bug tree-optimization/106112] New: wrong code at -Os and above on x86_64-linux-gnu zhendong.su at inf dot ethz.ch
2022-06-28 10:00 ` [Bug tree-optimization/106112] " zhendong.su at inf dot ethz.ch
2022-06-28 11:13 ` [Bug tree-optimization/106112] [10/11/12/13 Regression] wrong code at -Os and above on x86_64-linux-gnu since r10-2711-g3ed01d5408045d80 marxin at gcc dot gnu.org
2022-06-28 11:54 ` rguenth at gcc dot gnu.org [this message]
2022-06-29  9:15 ` cvs-commit at gcc dot gnu.org
2022-06-29  9:18 ` [Bug tree-optimization/106112] [10/11/12 " rguenth at gcc dot gnu.org
2022-07-19 11:38 ` cvs-commit at gcc dot gnu.org
2022-10-11 13:04 ` [Bug tree-optimization/106112] [10/11 " cvs-commit at gcc dot gnu.org
2022-10-14 10:47 ` [Bug tree-optimization/106112] [10 " cvs-commit at gcc dot gnu.org
2022-10-14 10:47 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106112-4-K35Fg7D8MR@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).