From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 6680638582AC; Wed, 18 Jan 2023 11:29:22 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6680638582AC
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1674041362;
	bh=MQiNU1ChgUtAa827abna8U8L4GqxLwPUs6ftqtPOZxI=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=STQj20ThxQFjVqsy2zwt9OWZPXX/zF1RA5LAadbxkyzQh13k/lkDdpyhk4ND6JAqz
	 +42GoMbKrtwQHvoXuuZUiDQCIW0UHTDg2388elVEsA75gwVKK87JO5V57RrV4/VR1x
	 mogZtTqFAcqhiVBqWhVcbwoBDdcdUxjtQxf9vZkE=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/106183] std::atomic::wait might fail to be unblocked
 by notify_one/all on platforms without platform_wait()
Date: Wed, 18 Jan 2023 11:29:19 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: redi at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106183-4-KN1cpWaGjI@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106183-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106183-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106183

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:ed58809ea1a8ccc1829d830799d34aa51e51d39e

commit r11-10472-ged58809ea1a8ccc1829d830799d34aa51e51d39e
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Jul 28 16:15:58 2022 +0100

    libstdc++: Unblock atomic wait on non-futex platforms [PR106183]

    When using a mutex and condition variable, the notifying thread needs to
    increment _M_ver while holding the mutex lock, and the waiting thread
    needs to re-check after locking the mutex. This avoids a missed
    notification as described in the PR.

    By moving the increment of _M_ver to the base _M_notify we can make the
    use of the mutex local to the use of the condition variable, and
    simplify the code a little. We can use a relaxed store because the mutex
    already provides sequential consistency. Also we don't need to check
    whether __addr =3D=3D &_M_ver because we know that's always true for
    platforms that use a condition variable, and so we also know that we
    always need to use notify_all() not notify_one().

    Reviewed-by: Thomas Rodgers <trodgers@redhat.com>

    libstdc++-v3/ChangeLog:

            PR libstdc++/106183
            * include/bits/atomic_wait.h (__waiter_pool_base::_M_notify):
            Move increment of _M_ver here.
            [!_GLIBCXX_HAVE_PLATFORM_WAIT]: Lock mutex around increment.
            Use relaxed memory order and always notify all waiters.
            (__waiter_base::_M_do_wait) [!_GLIBCXX_HAVE_PLATFORM_WAIT]:
            Check value again after locking mutex.
            (__waiter_base::_M_notify): Remove increment of _M_ver.

    (cherry picked from commit af98cb88eb4be6a1668ddf966e975149bf8610b1)=