From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 144053858408; Wed,  6 Jul 2022 18:27:06 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 144053858408
From: "dmalcolm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/106218] New: Analyzer false positives with Linux
 kernel's err.h
Date: Wed, 06 Jul 2022 18:27:05 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: analyzer
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dmalcolm at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: dmalcolm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-106218-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jul 2022 18:27:06 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106218

            Bug ID: 106218
           Summary: Analyzer false positives with Linux kernel's err.h
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: dmalcolm at gcc dot gnu.org
  Target Milestone: ---

The Linux kernel has a header include/linux/err.h which stuffs small negati=
ve
values into pointers.

The analyzer's constraint handling doesn't handle this very well at the mom=
ent.
 For example:

extern void __analyzer_dump_path (void);

long __attribute__((noinline))
PTR_ERR(const void *ptr) {
  return (long)ptr;
}

_Bool __attribute__((noinline))
IS_ERR(const void *ptr) {
  return (unsigned long)(void *)((unsigned long)ptr) >=3D (unsigned long)-4=
095;
}

long __attribute__((noinline))
test(void *ptr)
{
  if (IS_ERR(ptr)) {
    int err =3D PTR_ERR(ptr);
    if (!err)
      __analyzer_dump_path (); // BUG: shouldn't get here
  }
}

In the above -analyzer erroneously considers there to be a feasible executi=
on
path in which IS_ERR(ptr) and PTR_ERR(err) =3D=3D 0.

(minimized from a false positive in ipc/shm.c)=