public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/106259] [10/11/12/13 Regression] ICE in diag_mismatched_tags, at cp/parser.cc:33896 Date: Thu, 02 Mar 2023 16:02:09 +0000 [thread overview] Message-ID: <bug-106259-4-TgHMH4CST6@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106259-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106259 --- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>: https://gcc.gnu.org/g:71afd0628419c5d670701cb35bc9860380c7d9fb commit r13-6417-g71afd0628419c5d670701cb35bc9860380c7d9fb Author: Marek Polacek <polacek@redhat.com> Date: Wed Mar 1 14:28:46 2023 -0500 c++: ICE with -Wmismatched-tags and member template [PR106259] -Wmismatched-tags warns about the (harmless) struct/class mismatch. For, e.g., template<typename T> struct A { }; class A<int> a; it works by adding A<T> to the class2loc hash table while parsing the class-head and then, while parsing the elaborate type-specifier, we add A<int>. At the end of c_parse_file we go through the table and warn about the class-key mismatches. In this PR we crash though; we have template<typename T> struct A { template<typename U> struct W { }; }; struct A<int>::W<int> w; // #1 where while parsing A and #1 we've stashed A<T> A<T>::W<U> A<int>::W<int> into class2loc. Then in class_decl_loc_t::diag_mismatched_tags TYPE is A<int>::W<int>, and specialization_of gets us A<int>::W<U>, which is not in class2loc, so we crash on gcc_assert (cdlguide). But it's OK not to have found A<int>::W<U>, we should just look one "level" up, that is, A<T>::W<U>. It's important to handle class specializations, so e.g. template<> struct A<char> { template<typename U> class W { }; }; where W's class-key is different than in the primary template above, so we should warn depending on whether we're looking into A<char> or into a different instantiation. PR c++/106259 gcc/cp/ChangeLog: * parser.cc (class_decl_loc_t::diag_mismatched_tags): If the first lookup of SPEC didn't find anything, try to look for most_general_template. gcc/testsuite/ChangeLog: * g++.dg/warn/Wmismatched-tags-11.C: New test.
next prev parent reply other threads:[~2023-03-02 16:02 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-11 18:57 [Bug c++/106259] New: " gscfq@t-online.de 2022-07-11 19:23 ` [Bug c++/106259] [10/11/12/13 Regression] " mpolacek at gcc dot gnu.org 2022-07-11 19:29 ` mpolacek at gcc dot gnu.org 2023-02-28 20:43 ` mpolacek at gcc dot gnu.org 2023-03-01 16:12 ` mpolacek at gcc dot gnu.org 2023-03-01 17:05 ` mpolacek at gcc dot gnu.org 2023-03-02 16:02 ` cvs-commit at gcc dot gnu.org [this message] 2023-03-02 16:06 ` [Bug c++/106259] [10/11/12 " mpolacek at gcc dot gnu.org 2023-03-04 17:52 ` cvs-commit at gcc dot gnu.org 2023-03-04 18:16 ` [Bug c++/106259] [10/11 " mpolacek at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106259-4-TgHMH4CST6@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).