From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 07D70385383B; Fri, 14 Oct 2022 13:07:18 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 07D70385383B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1665752839;
	bh=9ZMY1lvJI50IzUFoA2lhYCepkqVmKISKlYljEQaVZps=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=FKvI2CbbQ3R1QU8xvSR7zCHOsGMvp4F621FwzMTVtl54A2Bd7uVlqAXHsYHAWS7l/
	 EnU0BezE32S99CJ3oi4RWz1131TW+FeyUJUpdRE5vchrUvacylavli3NjP2NFB3jOP
	 ahXioGPBc5wijc8fDaj2oWmtVqrIOWQ5kEc4Ds2E=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/106304] [modules] ICE compiling dynamic_cast in constexpr
 function (in tree_node, at cp/module.cc:9183)
Date: Fri, 14 Oct 2022 13:07:18 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106304-4-z4qzYftCEL@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106304-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106304-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106304

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:d6a488f243acfac4bdbbb0eefbee3ae916159cf5

commit r13-3299-gd6a488f243acfac4bdbbb0eefbee3ae916159cf5
Author: Patrick Palka <ppalka@redhat.com>
Date:   Fri Oct 14 09:07:01 2022 -0400

    c++ modules: ICE with dynamic_cast [PR106304]

    The FUNCTION_DECL we build for __dynamic_cast has an empty DECL_CONTEXT
    but trees_out::tree_node expects FUNCTION_DECLs to have non-empty
    DECL_CONTEXT, thus we crash when streaming out the dynamic_cast in the
    below testcase.

    This patch naively fixes this by setting DECL_CONTEXT for __dynamic_cast
    appropriately.  I suppose we should push it into the namespace too, like
    we do for __cxa_atexit which is similarly lazily declared.

            PR c++/106304

    gcc/cp/ChangeLog:

            * constexpr.cc (cxx_dynamic_cast_fn_p): Check for abi_node
            instead of global_namespace.
            * rtti.cc (build_dynamic_cast_1): Set DECL_CONTEXT and
            DECL_SOURCE_LOCATION when building dynamic_cast_node.  Push
            it into the namespace.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/pr106304_a.C: New test.
            * g++.dg/modules/pr106304_b.C: New test.=