public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/106390] Support gsl::owner<T> and/or [[gnu::owner]] attribute in -fanalyzer
Date: Thu, 21 Jul 2022 17:46:19 +0000	[thread overview]
Message-ID: <bug-106390-4-vJdaVNwIVH@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106390-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106390

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
As well as checking that destructors free an "owned" member, check that move
constructors and move assignments transfer ownership correctly, i.e. leave the
previous owner empty, and for move assignment, ensure any previous value in the
LHS is freed before being replaced i.e. given class Foo with member
gsl::owner<T*> m_ptr:

Foo&
Foo::operator=(Foo& rhs)
{
  m_ptr = rhs.m_ptr;
  rhs.m_ptr = nullptr;
  return *this;
}

flag a bug, because the previous value of m_ptr is overwritten without freeing
it.

  parent reply	other threads:[~2022-07-21 17:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 17:38 [Bug analyzer/106390] New: " redi at gcc dot gnu.org
2022-07-21 17:43 ` [Bug analyzer/106390] " redi at gcc dot gnu.org
2022-07-21 17:46 ` redi at gcc dot gnu.org [this message]
2023-06-08 17:00 ` vultkayn at gcc dot gnu.org
2023-06-08 19:17 ` redi at gcc dot gnu.org
2023-06-08 19:44 ` vultkayn at gcc dot gnu.org
2024-03-04 15:58 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106390-4-vJdaVNwIVH@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).