public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/106448] [OpenMP] atomic compare – g++ wrongly accepts parenthesized condition
Date: Fri, 29 Jul 2022 08:00:54 +0000	[thread overview]
Message-ID: <bug-106448-4-IVgmy8qQyU@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106448-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106448

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:2dcceedb3c121f2498ae58d8414e7b8454b7bf55

commit r13-1888-g2dcceedb3c121f2498ae58d8414e7b8454b7bf55
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Jul 29 09:59:19 2022 +0200

    openmp: Reject invalid forms of C++ #pragma omp atomic compare [PR106448]

    The allowed syntaxes of atomic compare don't allow ()s around the condition
    of ?:, but we were accepting it in one case for C++.

    Fixed thusly.

    2022-07-29  Jakub Jelinek  <jakub@redhat.com>

            PR c++/106448
            * parser.cc (cp_parser_omp_atomic): For simple cast followed by
            CPP_QUERY token, don't try cp_parser_binary_operation if compare
            is true.

            * c-c++-common/gomp/atomic-32.c: New test.

  parent reply	other threads:[~2022-07-29  8:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26 16:02 [Bug c++/106448] New: " burnus at gcc dot gnu.org
2022-07-27 16:07 ` [Bug c++/106448] " jakub at gcc dot gnu.org
2022-07-27 16:07 ` jakub at gcc dot gnu.org
2022-07-28 13:32 ` jakub at gcc dot gnu.org
2022-07-28 14:05 ` jakub at gcc dot gnu.org
2022-07-29  8:00 ` cvs-commit at gcc dot gnu.org [this message]
2022-07-29  8:05 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106448-4-IVgmy8qQyU@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).