public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/106448] New: [OpenMP] atomic compare – g++ wrongly accepts parenthesized condition
Date: Tue, 26 Jul 2022 16:02:44 +0000	[thread overview]
Message-ID: <bug-106448-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106448

            Bug ID: 106448
           Summary: [OpenMP] atomic compare – g++ wrongly accepts
                    parenthesized condition
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: accepts-invalid, diagnostic, openmp
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
                CC: jakub at gcc dot gnu.org
  Target Milestone: ---

The following code is rejected by gcc - but accepted by g++.
(Found via OpenMP examples Issue #291.)

OpenMP permits:
   x = expr ordop x ? expr : x;
   x = x ordop expr ? expr : x;21
   x = x == e ? d : x;

If one now parenthesis the condition, gcc rightly complains:

  error: invalid form of ‘#pragma omp atomic’ before ‘;’ token
    7 |   x = (expr > x) ? expr : x;
      |                            ^

However, g++ accepts that version without an error.


Note that g++ rejects the reverse version already:
 error: invalid form of ‘#pragma omp atomic’ before ‘(’ token
   10 |   x = (x < expr) ? expr : x;  // Rejected by g++ and gcc
      |       ^

--------------
int x, expr;

void
foo (void)
{
  #pragma omp atomic compare
  x = (expr > x) ? expr : x;  // Accepted by g++ [BUG!], rejected by gcc

  #pragma omp atomic compare
  x = (x < expr) ? expr : x;  // Rejected by g++ and gcc

  #pragma omp atomic compare
  x = (x == expr) ? expr : x;  // Rejected by g++ and gcc
}

             reply	other threads:[~2022-07-26 16:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26 16:02 burnus at gcc dot gnu.org [this message]
2022-07-27 16:07 ` [Bug c++/106448] " jakub at gcc dot gnu.org
2022-07-27 16:07 ` jakub at gcc dot gnu.org
2022-07-28 13:32 ` jakub at gcc dot gnu.org
2022-07-28 14:05 ` jakub at gcc dot gnu.org
2022-07-29  8:00 ` cvs-commit at gcc dot gnu.org
2022-07-29  8:05 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106448-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).