public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/106449] ICE in #pragma omp parallel for simd since r6-4544-ge01d41e553aae245
Date: Fri, 29 Jul 2022 07:54:31 +0000	[thread overview]
Message-ID: <bug-106449-4-9r1HYK6UQB@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106449-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106449

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:97d32048c04e9787fccadc4bae1c042754503e34

commit r13-1887-g97d32048c04e9787fccadc4bae1c042754503e34
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Jul 29 09:49:11 2022 +0200

    openmp: Fix up handling of non-rectangular simd loops with pointer type
iterators [PR106449]

    There were 2 issues visible on this new testcase, one that we didn't have
    special POINTER_TYPE_P handling in a few spots of expand_omp_simd - for
    pointers we need to use POINTER_PLUS_EXPR and need to have the non-pointer
    part in sizetype, for non-rectangular loop on the other side we can rely on
    multiplication factor 1, pointers can't be multiplied, without those
changes
    we'd ICE.  The other issue was that we put n2 expression directly into a
    comparison in a condition and regimplified that, for the &a[512] case that
    and with gimplification being destructed that unfortunately meant
modification
    of original fd->loops[?].n2.  Fixed by unsharing the expression.  This was
    causing a runtime failure on the testcase.

    2022-07-29  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/106449
            * omp-expand.cc (expand_omp_simd): Fix up handling of pointer
            iterators in non-rectangular simd loops.  Unshare fd->loops[i].n2
            or n2 before regimplifying it inside of a condition.

            * testsuite/libgomp.c-c++-common/pr106449.c: New test.

  parent reply	other threads:[~2022-07-29  7:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26 16:10 [Bug middle-end/106449] New: ICE in #pragma omp parallel for simd sandra at gcc dot gnu.org
2022-07-26 19:46 ` [Bug middle-end/106449] " burnus at gcc dot gnu.org
2022-07-27  7:10 ` rguenth at gcc dot gnu.org
2022-07-27  8:35 ` [Bug middle-end/106449] ICE in #pragma omp parallel for simd since r6-4544-ge01d41e553aae245 marxin at gcc dot gnu.org
2022-07-27 11:05 ` jakub at gcc dot gnu.org
2022-07-27 12:19 ` jakub at gcc dot gnu.org
2022-07-27 14:07 ` jakub at gcc dot gnu.org
2022-07-27 14:35 ` burnus at gcc dot gnu.org
2022-07-27 15:26 ` burnus at gcc dot gnu.org
2022-07-28 10:11 ` jakub at gcc dot gnu.org
2022-07-28 10:12 ` jakub at gcc dot gnu.org
2022-07-29  7:54 ` cvs-commit at gcc dot gnu.org [this message]
2022-07-29  8:06 ` jakub at gcc dot gnu.org
2022-07-30  9:34 ` cvs-commit at gcc dot gnu.org
2022-07-30 10:09 ` jakub at gcc dot gnu.org
2022-11-03 14:09 ` jakub at gcc dot gnu.org
2022-11-28 22:08 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106449-4-9r1HYK6UQB@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).