From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 9003E3852768; Sat, 30 Jul 2022 09:34:52 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9003E3852768
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/106449] ICE in #pragma omp parallel for simd since
 r6-4544-ge01d41e553aae245
Date: Sat, 30 Jul 2022 09:34:52 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: ice-on-valid-code, openmp
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106449-4-yTEbsPmkSd@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106449-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106449-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Jul 2022 09:34:52 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106449

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:681c73db9bd156f9b65a73ccc6c4a0a697fe70d6

commit r12-8645-g681c73db9bd156f9b65a73ccc6c4a0a697fe70d6
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Jul 29 09:49:11 2022 +0200

    openmp: Fix up handling of non-rectangular simd loops with pointer type
iterators [PR106449]

    There were 2 issues visible on this new testcase, one that we didn't ha=
ve
    special POINTER_TYPE_P handling in a few spots of expand_omp_simd - for
    pointers we need to use POINTER_PLUS_EXPR and need to have the non-poin=
ter
    part in sizetype, for non-rectangular loop on the other side we can rel=
y on
    multiplication factor 1, pointers can't be multiplied, without those
changes
    we'd ICE.  The other issue was that we put n2 expression directly into a
    comparison in a condition and regimplified that, for the &a[512] case t=
hat
    and with gimplification being destructed that unfortunately meant
modification
    of original fd->loops[?].n2.  Fixed by unsharing the expression.  This =
was
    causing a runtime failure on the testcase.

    2022-07-29  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/106449
            * omp-expand.cc (expand_omp_simd): Fix up handling of pointer
            iterators in non-rectangular simd loops.  Unshare fd->loops[i].=
n2
            or n2 before regimplifying it inside of a condition.

            * testsuite/libgomp.c-c++-common/pr106449.c: New test.

    (cherry picked from commit 97d32048c04e9787fccadc4bae1c042754503e34)=