From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 974F43858289; Tue, 23 May 2023 20:05:17 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 974F43858289
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1684872317;
	bh=vOU5J8fTKVXTbx02LKeRLum2rLi0lKOsIfVrf2vvPhk=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=q4RGrzmqsPhBEaQMpuPMvxPXlyXhziiCgklsEqKlAI3XU36I8WOaaM+84VHVv5zq4
	 n2WNRkBnz5WBGyFGFKYvjsYEQ+FdNaBzUegRAkIqNI3SBlZTIDyLj1PX3jJBT/urWh
	 brEZxueh+kwwDVFlm2bQTMDPqdAROuy3eF8A9pD0=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/106465] ICE for VLA in struct in parameter of nested function
Date: Tue, 23 May 2023 20:05:16 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: DUPLICATE
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106465-4-qX8RzbPMoL@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106465-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106465-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106465

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Uecker <uecker@gcc.gnu.org>:

https://gcc.gnu.org/g:f9b5be322358ee63798e02a9103b6bbe459e7aea

commit r14-1142-gf9b5be322358ee63798e02a9103b6bbe459e7aea
Author: Martin Uecker <uecker@tugraz.at>
Date:   Thu Apr 13 19:37:12 2023 +0200

    Fix ICEs related to VM types in C 1/2 [PR70418, PR107557, PR108423]

    Size expressions were sometimes lost and not gimplified correctly, lead=
ing
to
    ICEs and incorrect evaluation order.  Fix this by 1) not recursing into
    pointers when gimplifying parameters in the middle-end (the code is mer=
ged
with
    gimplify_type_sizes), which is incorrect because it might access variab=
les
    declared later for incomplete structs, and 2) tracking size expressions=
 for
    struct/union members correctly, 3) emitting code to evaluate size
expressions
    for missing cases (nested functions, empty declarations, and
structs/unions).

            PR c/70418
            PR c/106465
            PR c/107557
            PR c/108423

            gcc/c/
            * c-decl.cc (start_decl): Make sure size expression are
            evaluated only in correct context.
            (grokdeclarator): Size expression in fields may need a bind
            expression, make sure DECL_EXPR is always created.
            (grokfield, declspecs_add_type): Pass along size expressions.
            (finish_struct): Remove unneeded DECL_EXPR.
            (start_function): Evaluate size expressions for nested function=
s.
            * c-parser.cc (c_parser_struct_declarations,
            c_parser_struct_or_union_specifier): Pass along size expression=
s.
            (c_parser_declaration_or_fndef): Evaluate size expression.
            (c_parser_objc_at_property_declaration,
            c_parser_objc_class_instance_variables): Adapt.
            * c-tree.h (grokfield): Adapt declaration.

            gcc/testsuite/
            * gcc.dg/nested-vla-1.c: New test.
            * gcc.dg/nested-vla-2.c: New test.
            * gcc.dg/nested-vla-3.c: New test.
            * gcc.dg/pr70418.c: New test.
            * gcc.dg/pr106465.c: New test.
            * gcc.dg/pr107557-1.c: New test.
            * gcc.dg/pr107557-2.c: New test.
            * gcc.dg/pr108423-1.c: New test.
            * gcc.dg/pr108423-2.c: New test.
            * gcc.dg/pr108423-3.c: New test.
            * gcc.dg/pr108423-4.c: New test.
            * gcc.dg/pr108423-5.c: New test.
            * gcc.dg/pr108423-6.c: New test.
            * gcc.dg/typename-vla-2.c: New test.
            * gcc.dg/typename-vla-3.c: New test.
            * gcc.dg/typename-vla-4.c: New test.
            * gcc.misc-tests/gcov-pr85350.c: Adapt.=