public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rsaxvc at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/106484] New: Failure to optimize uint64_t/constant division on ARM32 Date: Sat, 30 Jul 2022 18:38:29 +0000 [thread overview] Message-ID: <bug-106484-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106484 Bug ID: 106484 Summary: Failure to optimize uint64_t/constant division on ARM32 Product: gcc Version: 12.1.0 Status: UNCONFIRMED Keywords: missed-optimization Severity: normal Priority: P3 Component: target Assignee: unassigned at gcc dot gnu.org Reporter: rsaxvc at gmail dot com Target Milestone: --- Target: arm The following test function compiles into a call to __aeabi_uldivmod, even though the divisor is a constant. Here's an example function: #include <stdint.h> uint64_t ns_to_s( uint64_t ns64 ) { return ns64 / 1000000000ULL; } CortexM4(-O3 -Wall -Wextra -mcpu=cortex-m4) assembly: ns_to_s(unsigned long long): push {r3, lr} adr r3, .L4 ldrd r2, [r3] bl __aeabi_uldivmod pop {r3, pc} .L4: .word 1000000000 .word 0 Interestingly, gcc 12.1 for aarch64 compiles the above C function by implementing division by a constant with scaled multiplication by the inverse using the umulh instruction(not present on 32-bit ARM). (-O3 -Wall -Wextra): ns_to_s(unsigned long): mov x1, 23123 lsr x0, x0, 9 movk x1, 0xa09b, lsl 16 movk x1, 0xb82f, lsl 32 movk x1, 0x44, lsl 48 umulh x0, x0, x1 lsr x0, x0, 11 ret Instead, if something like __umulh could be added to libgcc, then GCC could use the constants generated in the aarch64 logic to implement uint64_t/constant division. Example umulh approach is attached. On Cortex-M4, the umulh-based approach is significantly faster, although this depends on the specific libc __aeabi_uldivmod linked against as well as the numerator.
next reply other threads:[~2022-07-30 18:38 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-30 18:38 rsaxvc at gmail dot com [this message] 2022-07-30 18:39 ` [Bug target/106484] " rsaxvc at gmail dot com 2022-07-30 22:29 ` pinskia at gcc dot gnu.org 2022-08-01 10:50 ` rearnsha at gcc dot gnu.org 2022-08-01 12:12 ` rsaxvc at gmail dot com 2023-05-04 12:55 ` rsaxvc at gmail dot com 2023-07-08 18:10 ` rsaxvc at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106484-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).