public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/106491] ICE when compiling ArmSVE intrinsics in PCH
Date: Wed, 21 Sep 2022 08:30:42 +0000	[thread overview]
Message-ID: <bug-106491-4-F4b1qttJ0m@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106491-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106491

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Richard Sandiford
<rsandifo@gcc.gnu.org>:

https://gcc.gnu.org/g:a1465af240ee28fc7fcb83877c6aea94f11fb32f

commit r12-8779-ga1465af240ee28fc7fcb83877c6aea94f11fb32f
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Wed Sep 21 09:30:31 2022 +0100

    aarch64: Fix GTY markup for arm_sve.h [PR106491]

    It turns out that GTY(()) markers in definitions like:

      GTY(()) tree scalar_types[NUM_VECTOR_TYPES];

    are not effective and are silently ignored.  The GTY(()) has
    to come after an extern or static.

    The externs associated with the SVE ACLE GTY variables are in
    aarch64-sve-builtins.h.  This file is not in tm_include_list because
    we don't want every target-facing file to include it.  It therefore
    isn't in the list of GC header files either.

    In this case that's a blessing in disguise, since the variables
    belong to a namespace and gengtype doesn't understand namespaces.
    I think the fix is instead to add an extra extern before each
    variable declaration, similarly to varasm.cc and vtable-verify.cc.
    (This works due to a "using namespace" at the end of the file.)

    gcc/
            PR target/106491
            * config/aarch64/aarch64-sve-builtins.cc (scalar_types)
            (acle_vector_types, acle_svpattern, acle_svprfop): Add GTY
            markup to (new) extern declarations instead of to the main
            definition.

    (cherry picked from commit 6bf5a704d36243c4c04b17a9408ebe881beb0051)

  parent reply	other threads:[~2022-09-21  8:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-31  9:09 [Bug c++/106491] New: " denis.yaroshevskij at gmail dot com
2022-07-31  9:15 ` [Bug target/106491] " pinskia at gcc dot gnu.org
2022-07-31 19:26 ` pinskia at gcc dot gnu.org
2022-07-31 19:33 ` pinskia at gcc dot gnu.org
2022-08-01 10:19 ` denis.yaroshevskij at gmail dot com
2022-08-01 22:29 ` denis.yaroshevskij at gmail dot com
2022-09-15 15:15 ` rsandifo at gcc dot gnu.org
2022-09-20 14:28 ` cvs-commit at gcc dot gnu.org
2022-09-20 14:30 ` rsandifo at gcc dot gnu.org
2022-09-21  8:30 ` cvs-commit at gcc dot gnu.org [this message]
2022-09-21  8:44 ` denis.yaroshevskij at gmail dot com
2022-09-21 13:17 ` cvs-commit at gcc dot gnu.org
2022-09-21 13:17 ` cvs-commit at gcc dot gnu.org
2022-09-21 13:19 ` rsandifo at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106491-4-F4b1qttJ0m@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).