From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id B10DF3857B87; Wed, 21 Sep 2022 13:17:53 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B10DF3857B87
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1663766273;
	bh=biHrJPGknNgTumlrGmKo3hpdDmnjPEThj9WtvhVm9Ys=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=d+yPdUDdX29fXhnqpNCUVoHGp5KPZ7x9maNEdx4CPMbU+wXBvKAufd3iplIF2P6Wm
	 mcijjYxJHhwTy4r4CwVpLzVn6RQaz2P7JRCe9FoRDalSzZaegG9XtcwfGqd4XMl5qg
	 SRCDsIuCR2eHin9CWAegfezatUF4+kYIRX0WHzGA=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/106491] ICE when compiling ArmSVE intrinsics in PCH
Date: Wed, 21 Sep 2022 13:17:53 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 11.2.0
X-Bugzilla-Keywords: GC, ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rsandifo at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106491-4-w6LEeEw1XK@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106491-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106491-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106491

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Sandiford
<rsandifo@gcc.gnu.org>:

https://gcc.gnu.org/g:c3fda946dedbb08df8eb46bb0120938c08f09742

commit r10-10996-gc3fda946dedbb08df8eb46bb0120938c08f09742
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Wed Sep 21 14:17:43 2022 +0100

    aarch64: Fix GTY markup for arm_sve.h [PR106491]

    It turns out that GTY(()) markers in definitions like:

      GTY(()) tree scalar_types[NUM_VECTOR_TYPES];

    are not effective and are silently ignored.  The GTY(()) has
    to come after an extern or static.

    The externs associated with the SVE ACLE GTY variables are in
    aarch64-sve-builtins.h.  This file is not in tm_include_list because
    we don't want every target-facing file to include it.  It therefore
    isn't in the list of GC header files either.

    In this case that's a blessing in disguise, since the variables
    belong to a namespace and gengtype doesn't understand namespaces.
    I think the fix is instead to add an extra extern before each
    variable declaration, similarly to varasm.cc and vtable-verify.cc.
    (This works due to a "using namespace" at the end of the file.)

    gcc/
            PR target/106491
            * config/aarch64/aarch64-sve-builtins.cc (scalar_types)
            (acle_vector_types, acle_svpattern, acle_svprfop): Add GTY
            markup to (new) extern declarations instead of to the main
            definition.

    (cherry picked from commit 6bf5a704d36243c4c04b17a9408ebe881beb0051)=