public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/106498] [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 since r13-1450-gd2a89866660945 Date: Mon, 01 Aug 2022 13:57:24 +0000 [thread overview] Message-ID: <bug-106498-4-COdqFTQywU@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106498-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106498 --- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> --- Confirmed. Before OMP expansion the loops do not define virtual operands. After OMP expansion there's (useless) loop-around virtual operands. SSA form is updated at #0 update_ssa (update_flags=2048) at /space/rguenther/src/gcc-clean/gcc/tree-into-ssa.cc:3377 #1 0x00000000023fad6d in expand_omp_taskreg (region=0x3614bb0) at /space/rguenther/src/gcc-clean/gcc/omp-expand.cc:1511 #2 0x000000000242a485 in expand_omp (region=0x3614bb0) at /space/rguenther/src/gcc-clean/gcc/omp-expand.cc:10353 #3 0x000000000242aac4 in execute_expand_omp () at /space/rguenther/src/gcc-clean/gcc/omp-expand.cc:10592 #4 0x000000000242ac3f in (anonymous namespace)::pass_expand_omp_ssa::execute ( this=0x349c290) at /space/rguenther/src/gcc-clean/gcc/omp-expand.cc:10681 #5 0x000000000126d265 in execute_one_pass ( pass=<opt_pass* 0x349c290 "ompexpssa"(174)>) which ends up adding this virtual def. The reason is a __builtin_GOMP_parallel but the use is in a if (0 != 0) guarded region (that's possibly outlined afterwards?). It's quite ugly, SSA omp-expansion performs update_ssa sometimes per stmt! SSA omp-expansion test coverage is quite weak and autopar isn't well maintained :/ I do have a patch for this particular case though.
next prev parent reply other threads:[~2022-08-01 13:57 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-01 10:32 [Bug tree-optimization/106498] New: [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 asolokha at gmx dot com 2022-08-01 11:17 ` [Bug tree-optimization/106498] [13 Regression] ICE in check_loop_closed_ssa_def, at tree-ssa-loop-manip.cc:645 since r13-1450-gd2a89866660945 marxin at gcc dot gnu.org 2022-08-01 13:22 ` rguenth at gcc dot gnu.org 2022-08-01 13:57 ` rguenth at gcc dot gnu.org [this message] 2022-08-02 6:40 ` cvs-commit at gcc dot gnu.org 2022-08-02 6:41 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106498-4-COdqFTQywU@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).