public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/106514] [12/13 Regression] ranger slowness in path query
Date: Tue, 09 Aug 2022 09:38:50 +0000	[thread overview]
Message-ID: <bug-106514-4-BfKFlBtaEF@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106514-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106514

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
For the testcase m_imports is so big because we have

...
  <bb 1198> [local count: 1073741824]:
  # c_1198 = PHI <c_1197(1196), c_2400(1197)>
  _599 = MEM[(unsigned int *)b_1201(D) + 2792B];
  d_2401 = _599 + d_2399;
  if (d_2399 > d_2401)
    goto <bb 1199>; [50.00%]
  else
    goto <bb 1200>; [50.00%]

  <bb 1199> [local count: 536870913]:
  c_2402 = c_1198 + 1;

  <bb 1200> [local count: 1073741824]:
  # c_1199 = PHI <c_1198(1198), c_2402(1199)>
  _600 = MEM[(unsigned int *)b_1201(D) + 2796B];
  d_2403 = _600 + d_2401;
  if (d_2401 > d_2403)
    goto <bb 1201>; [50.00%]
  else
    goto <bb 1202>; [50.00%]

so when back_threader::find_paths does ->compute_imports (.., bb 1200) we
walk up the whole d_2403 definition chain unbound (for PHIs we restrict
to edges on the path which is empty).  I realize that there's no good way
to pick up extra imports on the fly cheaply - we could handle it when
we prune local defs from the imports at which point we could add operands
but it's not clear to me that will be a good trade-off.  In fact
pruning imports looks suspicious as the final path-range query will
be limited there?  Likewise for any import we add via PHI-translation
we fail to add local def operands - we're only getting those from the
initial import compute which basically picks those from blocks dominating
the exit but no others.

I will experiment with re-wiring this.

  parent reply	other threads:[~2022-08-09  9:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03 13:53 [Bug tree-optimization/106514] New: " rguenth at gcc dot gnu.org
2022-08-03 13:53 ` [Bug tree-optimization/106514] " rguenth at gcc dot gnu.org
2022-08-03 16:11 ` amacleod at redhat dot com
2022-08-03 19:37 ` cvs-commit at gcc dot gnu.org
2022-08-04 18:29 ` cvs-commit at gcc dot gnu.org
2022-08-05 12:06 ` cvs-commit at gcc dot gnu.org
2022-08-09  8:24 ` cvs-commit at gcc dot gnu.org
2022-08-09  9:09 ` rguenth at gcc dot gnu.org
2022-08-09  9:38 ` rguenth at gcc dot gnu.org [this message]
2022-08-10 13:51 ` rguenth at gcc dot gnu.org
2022-08-11 13:01 ` cvs-commit at gcc dot gnu.org
2022-12-13 13:56 ` rguenth at gcc dot gnu.org
2022-12-13 14:02 ` rguenth at gcc dot gnu.org
2023-05-08 12:25 ` [Bug tree-optimization/106514] [12/13/14 " rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106514-4-BfKFlBtaEF@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).