[Bug tree-optimization/106556] New: [13 Regression] ICE in as_a, at value-range.h:399

[Bug tree-optimization/106556] New: [13 Regression] ICE in as_a, at value-range.h:399

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106556

            Bug ID: 106556
           Summary: [13 Regression] ICE in as_a, at value-range.h:399
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

gfortran 13.0.0 20220807 snapshot (g:ef54eb74cab17737804af2c404e6674ce07f87c9)
ICEs when compiling the following testcase, extracted from
gcc/testsuite/gfortran.dg/minlocval_1.f90, w/ -O1 -fnon-call-exceptions
-ftree-loop-if-convert:

  real :: a(2)

  a(:) = 1.0
  if (minloc (a, dim = 1).ne.1) STOP 1
end

% gfortran-13.0.0 -O1 -fnon-call-exceptions -ftree-loop-if-convert -c
rtqdudpz.f90
during GIMPLE pass: dom
rtqdudpz.f90:5:3:

    5 | end
      |   ^
internal compiler error: in as_a, at value-range.h:399
0x7afa1d irange& as_a<irange>(vrange&)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/value-range.h:399
0x7afa1d irange& as_a<irange>(vrange&)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/value-range.h:397
0x7afa1d vrange::operator=(vrange const&)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/value-range.cc:198
0x7afa1d vrange::operator=(vrange const&)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/value-range.cc:195
0x1da8dd1 gori_compute::compute_operand1_range(vrange&, gimple*, vrange const&,
tree_node*, fur_source&)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range-gori.cc:1076
0x1daa4af gori_compute::condexpr_adjust(vrange&, vrange&, gimple*, tree_node*,
tree_node*, tree_node*, fur_source&)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range-gori.cc:1404
0x1da0e96 fold_using_range::range_of_cond_expr(vrange&, gassign*, fur_source&)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range-fold.cc:1303
0x1da5511 fold_using_range::fold_stmt(vrange&, gimple*, fur_source&,
tree_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range-fold.cc:561
0x1d97ae3 gimple_ranger::fold_range_internal(vrange&, gimple*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range.cc:258
0x1d97ae3 gimple_ranger::range_of_stmt(vrange&, gimple*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range.cc:319
0x1d9678c gimple_ranger::range_on_entry(vrange&, basic_block_def*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range.cc:153
0x1d96ab0 gimple_ranger::range_on_exit(vrange&, basic_block_def*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range.cc:190
0x1d988d9 gimple_ranger::range_on_edge(vrange&, edge_def*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range.cc:234
0x1da15ec fold_using_range::range_of_phi(vrange&, gphi*, fur_source&)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range-fold.cc:802
0x1da54b0 fold_using_range::fold_stmt(vrange&, gimple*, fur_source&,
tree_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range-fold.cc:557
0x1d97ae3 gimple_ranger::fold_range_internal(vrange&, gimple*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range.cc:258
0x1d97ae3 gimple_ranger::range_of_stmt(vrange&, gimple*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range.cc:319
0x1d986c6 gimple_ranger::range_of_expr(vrange&, tree_node*, gimple*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/gimple-range.cc:126
0x10aa620 cprop_operand
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/tree-ssa-dom.cc:1839
0x10aca32 cprop_into_stmt
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220807/work/gcc-13-20220807/gcc/tree-ssa-dom.cc:1916

[Bug tree-optimization/106556] [13 Regression] ICE in as_a, at value-range.h:399

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106556

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug tree-optimization/106556] [13 Regression] ICE in as_a, at value-range.h:399

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106556

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Related to:
  _22 = _20 < limit.3_38;
  _7 = _22 != 0;
  pos.1_30 = _7 ? S.4_37 : pos.1_39;
  limit.3_31 = _7 ? _20 : limit.3_38;

[Bug tree-optimization/106556] [13 Regression] ICE in as_a, at value-range.h:399

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106556

Andrew Macleod <amacleod at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amacleod at redhat dot com

--- Comment #2 from Andrew Macleod <amacleod at redhat dot com> ---
its just an incorrect type during the gori operand caclulation process. Just
got missed during the introduction of support for other range types.

testing underway now.

[Bug tree-optimization/106556] [13 Regression] ICE in as_a, at value-range.h:399

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106556

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Macleod <amacleod@gcc.gnu.org>:

https://gcc.gnu.org/g:ef623bb58594958a7959f8f031f65a50eb0e5890

commit r13-1995-gef623bb58594958a7959f8f031f65a50eb0e5890
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Mon Aug 8 15:13:51 2022 -0400

    Evaluate condition arguments with the correct type.

    Processing of a cond_expr requires that a range of the correct type for the
    operands of the cond_expr is passed in.

            PR tree-optimization/106556
            gcc/
            * gimple-range-gori.cc (gori_compute::condexpr_adjust): Use the
              type of the cond_expr operands being evaluted.

            gcc/testsuite/
            * gfortran.dg/pr106556.f90: New.

[Bug tree-optimization/106556] [13 Regression] ICE in as_a, at value-range.h:399

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106556

Andrew Macleod <amacleod at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Andrew Macleod <amacleod at redhat dot com> ---
fixed.

--- Comment #5 from Andrew Macleod <amacleod at redhat dot com> ---
fixed.

[Bug tree-optimization/106556] [13 Regression] ICE in as_a, at value-range.h:399

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106556

Andrew Macleod <amacleod at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Andrew Macleod <amacleod at redhat dot com> ---
fixed.