public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/106577] [13 Regression] during RTL pass: subreg3 ICE: in extract_insn, at recog.cc:2791 (unrecognizable insn) with -O -mavx since r13-2006-ga56c1641e9d25e46
Date: Fri, 02 Dec 2022 10:09:47 +0000	[thread overview]
Message-ID: <bug-106577-4-g8XlksIbs5@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106577-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106577

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:b3237a2c6847993f92218b65f96ece9831a8bfb0

commit r13-4462-gb3237a2c6847993f92218b65f96ece9831a8bfb0
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Dec 2 11:08:45 2022 +0100

    i386: Save/restore recog_data in ix86_vector_duplicate_value [PR106577]

    On Tue, Aug 16, 2022 at 09:14:06AM +0100, Richard Sandiford via Gcc-patches
wrote:
    > IMO the correct low-effort fix is to save and restore recog_data
    > in ix86_vector_duplicate_value.  It's a relatively big copy,
    > but the current code is pretty wasteful anyway (allocating at
    > least a new SET and INSN for every query).  Compared to the
    > overhead of doing that, a copy to and from the stack shouldn't
    > be too bad.

    The following patch does that.
    It isn't the first spot in the compiler that does that, not even the first
    spot in the i386 backend.
    In i386-expand.cc beyond these 2 recog_memoized calls there is one in
    expand_vselect, but I think it is unlikely we'd run into these issues
trying
    to expand new permutations from splitters.

    2022-12-02  Jakub Jelinek  <jakub@redhat.com>

            PR target/106577
            * config/i386/i386-expand.cc (ix86_vector_duplicate_value):
Save/restore
            recog_data around recog_memoized calls.

            * gcc.target/i386/pr106577.c: New test.

  parent reply	other threads:[~2022-12-02 10:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10 11:29 [Bug target/106577] New: [13 Regression] during RTL pass: subreg3 ICE: in extract_insn, at recog.cc:2791 (unrecognizable insn) with -O -mavx zsojka at seznam dot cz
2022-08-10 11:31 ` [Bug target/106577] [13 Regression] during RTL pass: subreg3 ICE: in extract_insn, at recog.cc:2791 (unrecognizable insn) with -O -mavx since r13-2006-ga56c1641e9d25e46 marxin at gcc dot gnu.org
2022-08-10 13:11 ` rguenth at gcc dot gnu.org
2022-08-11  7:41 ` roger at nextmovesoftware dot com
2022-08-14  6:34 ` roger at nextmovesoftware dot com
2022-10-19 10:43 ` rguenth at gcc dot gnu.org
2022-12-02 10:09 ` cvs-commit at gcc dot gnu.org [this message]
2022-12-02 10:20 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106577-4-g8XlksIbs5@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).