From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 034043858C74; Thu, 11 Aug 2022 21:10:52 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 034043858C74
From: "jankowski938 at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/106582] Wrong code generation resulting in HardFault
Date: Thu, 11 Aug 2022 21:10:52 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 10.3.1
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jankowski938 at gmail dot com
X-Bugzilla-Status: WAITING
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-106582-4-TPlmgUlHFl@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106582-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106582-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Aug 2022 21:10:53 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106582

--- Comment #5 from Piotr <jankowski938 at gmail dot com> ---
(In reply to Andrew Pinski from comment #4)
> >
> 080157fe:   movs    r3, #0
> 08015800:   ldr.w   r2, [r9, #20]
> 08015804:   str     r2, [r3, #12]
>=20
> This is doing a store at the address 12 which is invalid normally.
> I suspect for your code you need -fno-delete-null-pointer-checks .
>=20
> Or you are missing a null pointer check.
>=20
> The code does:
>    if (pQueryChunk && ioIsValid(pRawChunk))
>    {
>     pQueryChunk->pSrcDriver =3D pRawChunk->pSrcDriver;
>    }
>    else
>    {
>     if (pParser)
>     {
>      pQueryChunk->pSrcDriver =3D pParser->pSourceDriver;
>     }
>    }
>=20
> But the store for "pQueryChunk->pSrcDriver" is not checked to see if
> pQueryChunk was a non-null pointer before doing the store after the check
> that pParser was a non-null pointer.
>=20
>=20
> That is I don't think this is a bug in GCC.

Thank you for debugging our code :)=20

1. that chunk was vetted earlier in this function, so there is no need to c=
heck
it again here.
2. Offset 12 is not invalid as it is a 32bits (not 64) platform and it is
natively aligned=