public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "absoler at smail dot nju.edu.cn" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/106615] New: redundant load and store introduced in if-true-branch
Date: Sun, 14 Aug 2022 15:48:42 +0000	[thread overview]
Message-ID: <bug-106615-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106615

            Bug ID: 106615
           Summary: redundant load and store introduced in if-true-branch
           Product: gcc
           Version: 12.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: absoler at smail dot nju.edu.cn
  Target Milestone: ---

Given the code:

int g_36 = 0x0B137D37L;
int *g_35 = &g_36;
int g_44[2] = {0x964071C1L,0x964071C1L};

unsigned char  func_1(void);
int * func_16(int * p_17, unsigned long int  p_18);
int * func_19(int * p_20);


unsigned char func_1() { func_16(func_19(g_35), g_44[1]); }
int* func_16(int *a, unsigned long int b) {
        unsigned int c=1;
        *a = g_44;
        if ((g_44[0] = c) <= b)
                ;
        else
                *a = 0;
}
int* func_19(int32_t *d) {
        g_44[1] |= g_36 ;
        return d;
}

when it's compiled on gcc-12.1 with option -O1, the generated asm code of
func_16 will be:

0000000000401186 <func_16>:
  401186:       b8 60 40 40 00          mov    $0x404060,%eax
  40118b:       89 07                   mov    %eax,(%rdi)
  40118d:       c7 05 c9 2e 00 00 01    movl   $0x1,0x2ec9(%rip)        #
404060 <g_44>
  401194:       00 00 00 
  401197:       b8 00 00 00 00          mov    $0x0,%eax
  40119c:       48 85 f6                test   %rsi,%rsi
  40119f:       74 02                   je     4011a3 <func_16+0x1d>
  4011a1:       8b 07                   mov    (%rdi),%eax    
 # rdi keep the address of g_36
  4011a3:       89 07                   mov    %eax,(%rdi)
  4011a5:       c3                      retq  

We can see g_36 will be loaded to %eax and stored back as is when the
if-condition is true. This operation should be redundant?

             reply	other threads:[~2022-08-14 15:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-14 15:48 absoler at smail dot nju.edu.cn [this message]
2022-08-14 16:28 ` [Bug tree-optimization/106615] " pinskia at gcc dot gnu.org
2024-02-16  5:56 ` absoler at smail dot nju.edu.cn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106615-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).