public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "dmalcolm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug analyzer/106625] New: RFE: support some symbolic values in -Wanalyzer-out-of-bounds Date: Mon, 15 Aug 2022 12:36:01 +0000 [thread overview] Message-ID: <bug-106625-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106625 Bug ID: 106625 Summary: RFE: support some symbolic values in -Wanalyzer-out-of-bounds Product: gcc Version: 13.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: analyzer Assignee: dmalcolm at gcc dot gnu.org Reporter: dmalcolm at gcc dot gnu.org Target Milestone: --- Currently -Wanalyzer-out-of-bounds only warns when: * the size of the memory access is constant, rather than symbolic, and * the capacity of the underlying memory region being accessed is constant, rather than symbolic, and * the offset of the memory access is constant, rather than symbolic I'd like to eventually generalize the warning so that it can "do something sensible" when at least some of the above are symbolic - for some meaning of "something sensible". I'm not quite sure what subset we can support, but -Wanalyzer-out-of-bounds should probably continue to restrict itself to "definitely out-of-bounds" cases. For example, consider the classic mistake in C of confusing the size vs length of a 0-terminated string: char * test_concat (const char *x, const char *y) { size_t len_x = __builtin_strlen (x); size_t len_y = __builtin_strlen (y); size_t sz = len_x + len_y; // BUG (root cause): forgot to add 1 for terminator; char *result = __builtin_malloc (sz); if (!result) return NULL; __builtin_memcpy (result, x, len_x); __builtin_memcpy (result + len_x, y, len_y); result[len_x + len_y] = '\0'; // BUG (symptom): off-by-one out-of-bounds write to heap return result; } Currently -Wanalyzer-out-of-bounds doesn't warn for this; it would be great if void region_model::check_region_bounds could handle this. Specifically, in this case, although the size of the access: result[len_x + len_y] = '\0'; is constant (1 byte), the offset of the access is symbolic (len_x + len_y), and the capacity of "result" is symbolic. That said the symbolic offset of the access and symbolic capacity of the base region are directly related, and the former is definitely wrong with respect to the latter.
next reply other threads:[~2022-08-15 12:36 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-15 12:36 dmalcolm at gcc dot gnu.org [this message] 2022-08-15 12:44 ` [Bug analyzer/106625] " dmalcolm at gcc dot gnu.org 2022-09-08 17:47 ` cvs-commit at gcc dot gnu.org 2022-10-06 20:00 ` dmalcolm at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106625-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).