public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/106654] [C++23] P1774 - Portable assumptions
Date: Wed, 14 Sep 2022 09:52:35 +0000	[thread overview]
Message-ID: <bug-106654-4-997fmDBDKo@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106654-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106654

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldyh at gcc dot gnu.org,
                   |                            |amacleod at redhat dot com,
                   |                            |jakub at gcc dot gnu.org,
                   |                            |jason at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Note, we'll need something similar for OpenMP #pragma omp assume
(C/C++/Fortran).

I thought we could represent it in the IL as:
  if (.IFN_ASSUME ())
    {
      if (!cond)
        __builtin_unreachable ();
    }
where .IFN_ASSUME would eventually be folded into false.  We'd need to teach
the ranger etc. to take advantage of the bbs guarded by .IFN_ASSUME () as if
the condition would be true, the inliner to try to discover SESE regions
guarded by that condition and ignore them for size estimation purposes and
perhaps have somewhat higher code growth limits into those regions.
Richi doesn't like that.

Another possibility is to represent these as:
  .IFN_ASSUME (outlined_fun, args...);
where the cond expression would be outlined into an artificial function.
Ranger and other optimization passes then could try to evaluate the body of
outlined_fun with the assumption that the function returns true (if it returns
false, then it is UB).  We'd never emit the artificial outlined functions into
assembly nor debug info, but would inline into them and try to optimize them
after IPA.  Would be nice to have callgraph order their post IPA opts before
functions that .IFN_ASSUME reference them.
Either the outlined functions could be created in the FEs (e.g. for C++ we
could perhaps partly use code that we use for lambda capture discoveries), but
the disadvantage would be that we'd need to do it 3 times.
So another option would be some new GENERIC/GIMPLE statement kind used for
these and lower it only at say gimple lowering time (we have a precedent of
creating
outlined functions at ompexp time for OpenMP expansion).

Thoughts on this?  Aldy/Andrew, do you think it is something the ranger could
handle?

  reply	other threads:[~2022-09-14  9:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 17:20 [Bug c++/106654] New: " mpolacek at gcc dot gnu.org
2022-09-14  9:52 ` jakub at gcc dot gnu.org [this message]
2022-09-14 11:23 ` [Bug c++/106654] " rguenth at gcc dot gnu.org
2022-09-14 11:26 ` rguenth at gcc dot gnu.org
2022-09-14 11:54 ` jakub at gcc dot gnu.org
2022-09-16  9:20 ` pilarlatiesa at gmail dot com
2022-09-16 16:48 ` jakub at gcc dot gnu.org
2022-09-17 11:34 ` aldyh at gcc dot gnu.org
2022-09-17 12:09 ` jason at gcc dot gnu.org
2022-09-17 12:12 ` aldyh at gcc dot gnu.org
2022-09-17 12:29 ` jason at gcc dot gnu.org
2022-09-17 18:32 ` aldyh at gcc dot gnu.org
2022-09-21 17:49 ` jakub at gcc dot gnu.org
2022-10-06  7:01 ` cvs-commit at gcc dot gnu.org
2022-10-07 14:20 ` jakub at gcc dot gnu.org
2022-10-08 10:45 ` jakub at gcc dot gnu.org
2022-10-18  8:40 ` cvs-commit at gcc dot gnu.org
2022-10-20  0:37 ` cvs-commit at gcc dot gnu.org
2022-10-20 19:43 ` cvs-commit at gcc dot gnu.org
2022-11-19  9:24 ` jakub at gcc dot gnu.org
2022-11-28 22:32 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106654-4-997fmDBDKo@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).