public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/106654] [C++23] P1774 - Portable assumptions Date: Wed, 14 Sep 2022 11:23:18 +0000 [thread overview] Message-ID: <bug-106654-4-iLmJ14emX7@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106654-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106654 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rguenth at gcc dot gnu.org --- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> --- Note my main dislike is because the former is essentially <if we run here, 'cond' must have hold> if (0) { if (!cond) __builtin_unreachable (); } <something where 'cond' should hold> that is, the assumption itself, not only its condition computation (and side-effects) are thrown away. With cond = .IFN_ASSUME (outlined_cond_computer, args...); if (!cond) __builtin_unreachable (); or as Jakub prefers with implicit unreachable, the side-effects we want to elide are in 'outlined_cond_computer' and we can later "optimize" the .IFN_ASSUME call to compute true. For ranger the difficulty in the latter form is that there will be assertions on 'args...', variables at the call site, but what they are is specified by outlined_cond_computer returning true. Consider _bool outlined_cond_computer (int i, int j) { return i_1(D) == j_2(D); } from [[assume(i == j)]]; we'd then have .IFN_ASSUME (cond_fn, i_2, j_5); and just like IPA does, we'd have to "connect" relations/ranges produced by outlined_cond_computer via argument positions. I think we can easily funnel in argument ranges from the caller and thus possibly compute outlined_cond_computer outgoing ranges for the arguments (only those are interesting!) on the "true" return edge. Complication is the IL is in another function, set_cfun is a bit expensive but in theory most things could be formulated in a way to not require 'cfun' be set "correctly". On the C++ frontend side I'd simply handle [[assume(expr)]] as if 'expr' were in a lambda -> bool with everything captured by value.
next prev parent reply other threads:[~2022-09-14 11:23 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-16 17:20 [Bug c++/106654] New: " mpolacek at gcc dot gnu.org 2022-09-14 9:52 ` [Bug c++/106654] " jakub at gcc dot gnu.org 2022-09-14 11:23 ` rguenth at gcc dot gnu.org [this message] 2022-09-14 11:26 ` rguenth at gcc dot gnu.org 2022-09-14 11:54 ` jakub at gcc dot gnu.org 2022-09-16 9:20 ` pilarlatiesa at gmail dot com 2022-09-16 16:48 ` jakub at gcc dot gnu.org 2022-09-17 11:34 ` aldyh at gcc dot gnu.org 2022-09-17 12:09 ` jason at gcc dot gnu.org 2022-09-17 12:12 ` aldyh at gcc dot gnu.org 2022-09-17 12:29 ` jason at gcc dot gnu.org 2022-09-17 18:32 ` aldyh at gcc dot gnu.org 2022-09-21 17:49 ` jakub at gcc dot gnu.org 2022-10-06 7:01 ` cvs-commit at gcc dot gnu.org 2022-10-07 14:20 ` jakub at gcc dot gnu.org 2022-10-08 10:45 ` jakub at gcc dot gnu.org 2022-10-18 8:40 ` cvs-commit at gcc dot gnu.org 2022-10-20 0:37 ` cvs-commit at gcc dot gnu.org 2022-10-20 19:43 ` cvs-commit at gcc dot gnu.org 2022-11-19 9:24 ` jakub at gcc dot gnu.org 2022-11-28 22:32 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106654-4-iLmJ14emX7@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).