From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 5337D3858C2B; Thu, 24 Aug 2023 23:39:20 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5337D3858C2B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1692920360;
	bh=DjFTslYoiIj/LOyTxrEJ34sCaNJoymponZs+/14ON0g=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=g3t2hIVR4Y70EUS6PR6cKubaLAnLI9iGrZ4BKy9a/5I8rYbLXcDjXMMvOckqjjBya
	 HxVJm17MY6kqW/JLXCp9aEzGW+J+KRa7FjOwTd5+pIzWLYA30eOTmkMHZl4UXtyHAk
	 FSNNmzJoTieFxO27j1HwvF6G9hGkwN9mp/vILp18=
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/106677] Abstraction overhead with
 std::views::join
Date: Thu, 24 Aug 2023 23:39:18 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cf_reconfirmed_on bug_status everconfirmed
Message-ID: <bug-106677-4-Ypnmr5jjrY@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-106677-4@http.gcc.gnu.org/bugzilla/>
References: <bug-106677-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D106677

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-08-24
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #3)
> On the trunk we now get:
>   _25 =3D SR.116_117 =3D=3D 0;
>   _27 =3D (unsigned char) _25;
>   _32 =3D _27 | SR.116_117;
>=20
> Rather than:
>   _119 =3D MAX_EXPR <1, SR.115_117>;
>=20
> But we should instead just get:
> SR.116_117 | 1
>=20
> Though that should still be transformed into 1 (will fix that seperately).
>=20
> I have a quick patch which fixes that, we need to move `a ? zero_one_valu=
e :
> zero_one_value` part of match.pd below the min/max detection.

The two patches for that.

https://gcc.gnu.org/pipermail/gcc-patches/2023-August/628405.html
https://gcc.gnu.org/pipermail/gcc-patches/2023-August/628404.html

I have not looked into the rest but otherwise confirmed.=