[Bug c++/106759] New: __has_builtin doesn't report __is_nothrow_constructible as supported

[Bug c++/106759] New: __has_builtin doesn't report __is_nothrow_constructible as supported

[nikolasklauser at berlin dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106759

            Bug ID: 106759
           Summary: __has_builtin doesn't report
                    __is_nothrow_constructible as supported
           Product: gcc
           Version: 12.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: nikolasklauser at berlin dot de
  Target Milestone: ---

__has_builtin normally reports if builtin type traits are supported, but
__has_builtin(__is_nothrow_constructible) is false.

Reproducer: (Godbolt: https://godbolt.org/z/T6d7M6jx7)

#if __has_builtin(__is_nothrow_constructible)
#  error "has builtin" // should error here, but doesn't
#endif

int main() { return __is_nothrow_constructible(int); }

[Bug c++/106759] __has_builtin doesn't report __is_nothrow_constructible as supported

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106759

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-08-26

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
diff --git a/gcc/cp/cp-objcp-common.cc b/gcc/cp/cp-objcp-common.cc
index 4079a4b4aec..1ffac08c32f 100644
--- a/gcc/cp/cp-objcp-common.cc
+++ b/gcc/cp/cp-objcp-common.cc
@@ -460,6 +460,8 @@ names_builtin_p (const char *name)
     case RID_IS_UNION:
     case RID_IS_ASSIGNABLE:
     case RID_IS_CONSTRUCTIBLE:
+    case RID_IS_NOTHROW_ASSIGNABLE:
+    case RID_IS_NOTHROW_CONSTRUCTIBLE:
     case RID_UNDERLYING_TYPE:
     case RID_REF_CONSTRUCTS_FROM_TEMPORARY:
     case RID_REF_CONVERTS_FROM_TEMPORARY:

[Bug c++/106759] __has_builtin doesn't report __is_nothrow_constructible as supported

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106759

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Are you going to post the patch or should I?

[Bug c++/106759] __has_builtin doesn't report __is_nothrow_constructible as supported

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106759

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Marek Polacek from comment #2)
> Are you going to post the patch or should I?

Can you do it? I don't have time to add a testcase and to double check all of
the RIDs. I just did the few I saw.

[Bug c++/106759] __has_builtin doesn't report __is_nothrow_constructible as supported

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106759

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Sure.

[Bug c++/106759] __has_builtin doesn't report __is_nothrow_constructible as supported

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106759

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:fe915f35b7d8dc768a2b977c09aa02f933e1d1e9

commit r13-2277-gfe915f35b7d8dc768a2b977c09aa02f933e1d1e9
Author: Marek Polacek <polacek@redhat.com>
Date:   Mon Aug 29 16:54:05 2022 -0400

    c++: __has_builtin gives the wrong answer [PR106759]

    We've supported __is_nothrow_constructible since r11-4386, but
    names_builtin_p didn't know about it, so it gave the wrong answer for
     #if __has_builtin(__is_nothrow_constructible)
     ...
     #endif

    I've tested all C++-only built-ins and only two were missing.

            PR c++/106759

    gcc/cp/ChangeLog:

            * cp-objcp-common.cc (names_builtin_p): Handle
RID_IS_NOTHROW_ASSIGNABLE
            and RID_IS_NOTHROW_CONSTRUCTIBLE.

    gcc/testsuite/ChangeLog:

            * g++.dg/ext/has-builtin-1.C: New test.

[Bug c++/106759] __has_builtin doesn't report __is_nothrow_constructible as supported

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106759

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Marek Polacek
<mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:29dfe1cacadd2a47b4e5b1cab11bd7263fe211c9

commit r12-8729-g29dfe1cacadd2a47b4e5b1cab11bd7263fe211c9
Author: Marek Polacek <polacek@redhat.com>
Date:   Mon Aug 29 16:54:05 2022 -0400

    c++: __has_builtin gives the wrong answer [PR106759]

    We've supported __is_nothrow_constructible since r11-4386, but
    names_builtin_p didn't know about it, so it gave the wrong answer for
     #if __has_builtin(__is_nothrow_constructible)
     ...
     #endif

    I've tested all C++-only built-ins and only two were missing.

            PR c++/106759

    gcc/cp/ChangeLog:

            * cp-objcp-common.cc (names_builtin_p): Handle
RID_IS_NOTHROW_ASSIGNABLE
            and RID_IS_NOTHROW_CONSTRUCTIBLE.

    gcc/testsuite/ChangeLog:

            * g++.dg/ext/has-builtin-1.C: New test.

    (cherry picked from commit fe915f35b7d8dc768a2b977c09aa02f933e1d1e9)

[Bug c++/106759] __has_builtin doesn't report __is_nothrow_constructible as supported

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106759

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed for GCC 13 and 12.3.